Continue cleanup of pseudo-scheduler daemon

Let it build by default for simplicity. Cleanup the
backend operations to remove things that aren't directly
part of the scheduler. Begin implementation of the sched
state machine.

Signed-off-by: Ralph Castain <rhc@pmix.org>

config/prte_configure_options.m4

@@ -383,15 +383,15 @@ AC_DEFINE_UNQUOTED([PRTE_ENABLE_GETPWUID], [$prte_want_getpwuid],
 AC_MSG_CHECKING([if want to install PRRTE pseudo-scheduler])
 AC_ARG_WITH(prte-scheduler,
     AS_HELP_STRING([--with-prte-scheduler],
-                   [Normal PRTE users/applications do not need this.  Users/applications wishing to explore dynamic allocation support probably do (default: disabled).]))
-if test "$with_prte_scheduler" = "yes"; then
-    AC_MSG_RESULT([yes])
-    prte_want_scheduler="yes"
-    WANT_PRTE_SCHED=1
-else
+                   [Normal PRTE users/applications do not need this.  Users/applications wishing to explore dynamic allocation support probably do (default: enabled).]))
+if test "$with_prte_scheduler" = "no"; then
     AC_MSG_RESULT([no])
     prte_want_scheduler="no"
     WANT_PRTE_SCHED=0
+else
+    AC_MSG_RESULT([yes])
+    prte_want_scheduler="yes"
+    WANT_PRTE_SCHED=1
 fi
 AM_CONDITIONAL(WANT_PRTE_SCHED, test "$WANT_PRTE_SCHED" = 1)
 PRTE_SUMMARY_ADD([Miscellaneous], [PRTE Pseudo-Scheduler], [], [$prte_want_scheduler])

src/mca/state/base/state_base_fns.c

@@ -114,13 +114,10 @@ void prte_state_base_activate_job_state(prte_job_t *jdata, prte_job_state_t stat
 
 int prte_state_base_add_job_state(prte_job_state_t state, prte_state_cbfunc_t cbfunc, int priority)
 {
-    pmix_list_item_t *item;
     prte_state_t *st;
 
     /* check for uniqueness */
-    for (item = pmix_list_get_first(&prte_job_states); item != pmix_list_get_end(&prte_job_states);
-         item = pmix_list_get_next(item)) {
-        st = (prte_state_t *) item;
+    PMIX_LIST_FOREACH(st, &prte_job_states, prte_state_t) {
         if (st->job_state == state) {
             PMIX_OUTPUT_VERBOSE((1, prte_state_base_framework.framework_output,
                                  "DUPLICATE STATE DEFINED: %s", prte_job_state_to_str(state)));

src/prted/pmix/pmix_server.c

@@ -968,6 +968,7 @@ void pmix_server_finalize(void)
     PMIX_LIST_DESTRUCT(&prte_pmix_server_globals.notifications);
     PMIX_LIST_DESTRUCT(&prte_pmix_server_globals.psets);
     PMIX_LIST_DESTRUCT(&prte_pmix_server_globals.groups);
+    PMIX_LIST_DESTRUCT(&prte_pmix_server_globals.tools);
 
     /* shutdown the local server */
     prte_pmix_server_globals.initialized = false;