RML Rework: Stage 3 - remove routed framework #1232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the routed/radix code to the RML directory. Signed-off-by: Ralph Castain <rhc@pmix.org>
|
This PR appears to have broken support for slurm PLM. See open-mpi/ompi#10153 |
hppritcha
added a commit
to hppritcha/prrte
that referenced
this pull request
Mar 23, 2022
PR openpmix#1232 broke support for srun based launch of prted's. The problem introduced had to do with the uncondtional of exchange of PRTE_RML_TAG_NODE_REGEX_REPORT tagged messages with its parent. The callback associated with this tag invokes plm methods that are only defined for the SSH PLM component. Prior to openpmix#1232, this code was only conditionally invoked such that the message exchange of type PRTE_RML_TAG_NODE_REGEX_REPORT only occurred when using the ssh PLM. This patch puts this conditional back in. Signed-off-by: Howard Pritchard <howardp@lanl.gov>
hppritcha
added a commit
to hppritcha/prrte
that referenced
this pull request
Mar 23, 2022
PR openpmix#1232 broke support for srun based launch of prted's. The problem introduced had to do with the unconditional exchange of PRTE_RML_TAG_NODE_REGEX_REPORT tagged messages with a parent. The callback associated with this tag invokes plm methods that are only defined for the SSH PLM component. Prior to openpmix#1232, this code was only conditionally invoked such that the message exchange of type PRTE_RML_TAG_NODE_REGEX_REPORT only occurred when using the ssh PLM. This patch puts this conditional back in. Related to open-mpi/ompi#10153 Signed-off-by: Howard Pritchard <howardp@lanl.gov>
rhc54
pushed a commit
that referenced
this pull request
Mar 24, 2022
PR #1232 broke support for srun based launch of prted's. The problem introduced had to do with the unconditional exchange of PRTE_RML_TAG_NODE_REGEX_REPORT tagged messages with a parent. The callback associated with this tag invokes plm methods that are only defined for the SSH PLM component. Prior to #1232, this code was only conditionally invoked such that the message exchange of type PRTE_RML_TAG_NODE_REGEX_REPORT only occurred when using the ssh PLM. This patch puts this conditional back in. Related to open-mpi/ompi#10153 Signed-off-by: Howard Pritchard <howardp@lanl.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the routed/radix code to the RML directory.
Signed-off-by: Ralph Castain rhc@pmix.org