Fix PMIx configury #1255
Closed
Fix PMIx configury #1255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commit after #1254 |
Need to add the "/pmix" subdirectory to the CPPFLAGS in order to find the PMIx devel headers Signed-off-by: Ralph Castain <rhc@pmix.org>
bwbarrett
suggested changes
Mar 9, 2022
| @@ -73,6 +73,7 @@ AC_DEFUN([PRTE_CHECK_PMIX],[ | |||
| AC_MSG_ERROR([Cannot continue.])]) | |||
|
|
|||
| prte_external_pmix_save_CPPFLAGS=$CPPFLAGS | |||
| PRTE_FLAGS_PREPEND_UNIQ(CPPFLAGS, $prte_pmix_CPPFLAGS/pmix) | |||
There was a problem hiding this comment.
This won't work in the general case. $prte_pmix_CPPFLAGS is likely to include more than one -I (for example, if it used pkg-config or pmixcc, it should contain -I${prefix}/include -I${prefix}/include/pmix). I thought I covered all the use cases such that you wouldn't need this. Can you open an issue with the output of configure (or config.log) from PRRTE and I'll sort out what went wrong?
There was a problem hiding this comment.
Okay - I'm puzzled how this made it thru our CI as all PRs are now failing. Very odd.
There was a problem hiding this comment.
Oh now this is really weird - it built correctly this time! I'll poke some more at this to see what's going on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to add the "/pmix" subdirectory to the CPPFLAGS in order
to find the PMIx devel headers
Signed-off-by: Ralph Castain rhc@pmix.org