Multiple commits #1556
Merged
Multiple commits #1556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure we pass pset membership when registering the job. Support backend queries of membership. Add example that exercises the code. Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit f756956)
Remove unused functions and entry points Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit 9e833e1)
Signed-off-by: Thomas Naughton <naughtont@ornl.gov> (cherry picked from commit 793e3bc)
Signed-off-by: Thomas Naughton <naughtont@ornl.gov> (cherry picked from commit 77c9359)
Signed-off-by: Thomas Naughton <naughtont@ornl.gov> (cherry picked from commit 10b256e)
Signed-off-by: Thomas Naughton <naughtont@ornl.gov> (cherry picked from commit e45def7)
Signed-off-by: Thomas Naughton <naughtont@ornl.gov> (cherry picked from commit f80a882)
Signed-off-by: Thomas Naughton <naughtont@ornl.gov> (cherry picked from commit 9c48d62)
Having two options that apply to all ranks and another nearly-identical one that only applies to specified ranks is confusing. It also is questionable as to whether it makes any sense to have some ranks run free while others are told to stop on exec. So just simplify things and have all three options be boolean. Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit 004d0e8)
Bring the branch up to target version Signed-off-by: Ralph Castain <rhc@pmix.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support query of pset membership
Ensure we pass pset membership when registering the job. Support
backend queries of membership. Add example that exercises the code.
Signed-off-by: Ralph Castain rhc@pmix.org
(cherry picked from commit f756956)
Cleanup grpcomm cruft
Remove unused functions and entry points
Signed-off-by: Ralph Castain rhc@pmix.org
(cherry picked from commit 9e833e1)
remove some unused vars
Signed-off-by: Thomas Naughton naughtont@ornl.gov
(cherry picked from commit 793e3bc)
squash warnings
Signed-off-by: Thomas Naughton naughtont@ornl.gov
(cherry picked from commit 77c9359)
unused var
Signed-off-by: Thomas Naughton naughtont@ornl.gov
(cherry picked from commit 10b256e)
more unused vars
Signed-off-by: Thomas Naughton naughtont@ornl.gov
(cherry picked from commit e45def7)
remove unused vars and fix rc/ret typo
Signed-off-by: Thomas Naughton naughtont@ornl.gov
(cherry picked from commit f80a882)
misc unused var cleanups
Signed-off-by: Thomas Naughton naughtont@ornl.gov
(cherry picked from commit 9c48d62)
Reduce debugger confusion
Having two options that apply to all ranks and another
nearly-identical one that only applies to specified ranks
is confusing. It also is questionable as to whether it makes
any sense to have some ranks run free while others are told
to stop on exec.
So just simplify things and have all three options be boolean.
Signed-off-by: Ralph Castain rhc@pmix.org
(cherry picked from commit 004d0e8)
Pickup missing changes
Bring the branch up to target version
Signed-off-by: Ralph Castain rhc@pmix.org
bot:notacherrypick