Multiple commits #1591
Merged
Multiple commits #1591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Naughton <naughtont@ornl.gov> (cherry picked from commit a0a06ed)
Signed-off-by: Thomas Naughton <naughtont@ornl.gov> (cherry picked from commit 91cb9c4)
Change from option to required arg for `prterun --dvm arg` and adjust namespace to mirror other cases by using a prefix of "ns:" when using a namespace to choose target DVM controller. Also add examples in help files for prterun to clarify these options in verbose info case (prterun --help --dvm) Also, update schizo/ompi with namespace example. Signed-off-by: Thomas Naughton <naughtont@ornl.gov> (cherry picked from commit b4c3e2c)
Failure to provide a known option should be reported to the user as an error, not silently assumed equivalent to the "search" option. Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit a8075b6)
Since this is to mimic the "prun" equivalent, add the system and system-first options as they may prove useful going forward. Consolidate the help text for easier maintenance. Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit f99fe3f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix conflict
Signed-off-by: Thomas Naughton naughtont@ornl.gov
(cherry picked from commit a0a06ed)
remove unused vars in tools area
Signed-off-by: Thomas Naughton naughtont@ornl.gov
(cherry picked from commit 91cb9c4)
adjust prterun to prefix ns: for dvm option
Change from option to required arg for
prterun --dvm argand adjust namespace to mirror other cases by using
a prefix of "ns:" when using a namespace to choose target DVM
controller.
Also add examples in help files for prterun to clarify
these options in verbose info case (prterun --help --dvm)
Also, update schizo/ompi with namespace example.
Signed-off-by: Thomas Naughton naughtont@ornl.gov
(cherry picked from commit b4c3e2c)
Cleanup the --dvm option a bit
Failure to provide a known option should be reported to
the user as an error, not silently assumed equivalent
to the "search" option.
Signed-off-by: Ralph Castain rhc@pmix.org
(cherry picked from commit a8075b6)
Some more minor cleanups of --dvm
Since this is to mimic the "prun" equivalent, add the
system and system-first options as they may prove useful
going forward. Consolidate the help text for easier maintenance.
Signed-off-by: Ralph Castain rhc@pmix.org
(cherry picked from commit f99fe3f)