Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple commits #1860

Merged
merged 9 commits into from
Nov 19, 2023
Merged

Multiple commits #1860

merged 9 commits into from
Nov 19, 2023

Conversation

rhc54
Copy link
Contributor

@rhc54 rhc54 commented Nov 19, 2023

prte.c: a prefix of "/" is ok

It's not an error if the prefix ends up being a plain "/". More
specifically, if we strip off all trailing "/" characters from the
prefix and end up with an empty string, then the prefix is just "/".

Protect against a NULL prefix being added to the app's attributes.

Protect against a double-/ in the prted cmd path in the ssh
launch component.

Signed-off-by: Jeff Squyres jeff@squyres.com
Signed-off-by: Ralph Castain rhc@pmix.org
(cherry picked from commit ce7f686)

Correctly translate the plm_rsh MCA params

Need to convert to plm_ssh

Signed-off-by: Ralph Castain rhc@pmix.org
(cherry picked from commit d7d0095)

Fix add-hostfile and add-host operations

When in a managed allocation, allow addition of nodes
provided that either (a) all the nodes in the managed
portion of the allocation have the same #slots in them
so we can infer how many are in the new nodes, or (b)
the user specifies the #slots for the new nodes.

Check node names as well as aliases for match.

Add a new ras component to simulate a managed allocation.

Signed-off-by: Ralph Castain rhc@pmix.org
(cherry picked from commit bffbc40)

Add print functions for node, job, and proc flags

Make it easier to understand what flags are set.

Signed-off-by: Ralph Castain rhc@pmix.org
(cherry picked from commit f4e67ac)

Add missing "acquire_object"

Ensure we have a memory barrier prior to
using the object when called from the
progress thread.

Signed-off-by: Ralph Castain rhc@pmix.org
(cherry picked from commit 2835e09)

Fix handling of "--" in cmd line

Allow the app parser to see the line and rely on
the PMIx cmd line parser to handle it.

Signed-off-by: Ralph Castain rhc@pmix.org
(cherry picked from commit 81b4e60)

Use global PRRTE event base for sigchld callback

Even when we utilize multiple odls progress threads
to locally fork/exec procs, we have to direct the
waitpid callback to the global event base to ensure
that all servicing of sigchld returns happens in a
thread-safe environment.

Remove the unused event base priorities as an
unnecessary distraction.

Signed-off-by: Ralph Castain rhc@pmix.org
(cherry picked from commit 066b560)

Remove the event base param to prte_wait_cb

Reduce potential for mistakes by locking the
wait callbacks to occur in the main event thread.

Signed-off-by: Ralph Castain rhc@pmix.org
(cherry picked from commit ad63c0f)

Fix OMPI cmd line processing

Don't touch provided values of MCA params when
converting single-dash to double-dash options.

Signed-off-by: Ralph Castain rhc@pmix.org
(cherry picked from commit 0da2000)

It's not an error if the prefix ends up being a plain "/".  More
specifically, if we strip off all trailing "/" characters from the
prefix and end up with an empty string, then the prefix is just "/".

Protect against a NULL prefix being added to the app's attributes.

Protect against a double-/ in the prted cmd path in the ssh
launch component.

Signed-off-by: Jeff Squyres <jeff@squyres.com>
Signed-off-by: Ralph Castain <rhc@pmix.org>
(cherry picked from commit ce7f686)
Need to convert to plm_ssh

Signed-off-by: Ralph Castain <rhc@pmix.org>
(cherry picked from commit d7d0095)
When in a managed allocation, allow addition of nodes
provided that either (a) all the nodes in the managed
portion of the allocation have the same #slots in them
so we can infer how many are in the new nodes, or (b)
the user specifies the #slots for the new nodes.

Check node names as well as aliases for match.

Add a new ras component to simulate a managed allocation.

Signed-off-by: Ralph Castain <rhc@pmix.org>
(cherry picked from commit bffbc40)
Make it easier to understand what flags are set.

Signed-off-by: Ralph Castain <rhc@pmix.org>
(cherry picked from commit f4e67ac)
Ensure we have a memory barrier prior to
using the object when called from the
progress thread.

Signed-off-by: Ralph Castain <rhc@pmix.org>
(cherry picked from commit 2835e09)
Allow the app parser to see the line and rely on
the PMIx cmd line parser to handle it.

Signed-off-by: Ralph Castain <rhc@pmix.org>
(cherry picked from commit 81b4e60)
Even when we utilize multiple odls progress threads
to locally fork/exec procs, we have to direct the
waitpid callback to the global event base to ensure
that all servicing of sigchld returns happens in a
thread-safe environment.

Remove the unused event base priorities as an
unnecessary distraction.

Signed-off-by: Ralph Castain <rhc@pmix.org>
(cherry picked from commit 066b560)
Reduce potential for mistakes by locking the
wait callbacks to occur in the main event thread.

Signed-off-by: Ralph Castain <rhc@pmix.org>
(cherry picked from commit ad63c0f)
Don't touch provided values of MCA params when
converting single-dash to double-dash options.

Signed-off-by: Ralph Castain <rhc@pmix.org>
(cherry picked from commit 0da2000)
@rhc54 rhc54 merged commit 9072e6f into openpmix:v3.0 Nov 19, 2023
12 checks passed
@rhc54 rhc54 deleted the cmr30/up branch November 19, 2023 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant