Multiple commits #1884
Merged
Multiple commits #1884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use correct variable in comparison code. Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit 6b45a6f)
Makes no sense to allow prterun to daemonize given that it is intended to execute a single job and then terminate. You can still run it in the background, if desired. Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit 9c94e2a)
Some bit rot had crept in, and we need to not check managed allocations for non-uniformity if we aren't actually adding hosts or hostfiles. Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit e09c049)
For earlier versions of PMIx, we won't have access to the pmix_getline utility - so preserve the static versions of that function where required for those earlier versions. Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit 951af44)
Need to check the PMIx version at runtime to ensure it meets the minimum requirements. Can only do this where supported (i.e., PMIx v4.2.7 and above). Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit eefd2b4)
Wasn't made globally visible until PMIx v4.2.8 Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit ef54abf)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix copy/paste error
Use correct variable in comparison code.
Signed-off-by: Ralph Castain rhc@pmix.org
(cherry picked from commit 6b45a6f)
Remove daemonize option from prterun
Makes no sense to allow prterun to daemonize given that
it is intended to execute a single job and then terminate.
You can still run it in the background, if desired.
Signed-off-by: Ralph Castain rhc@pmix.org
(cherry picked from commit 9c94e2a)
Fix the ras simulator module
Some bit rot had crept in, and we need to not check managed
allocations for non-uniformity if we aren't actually adding
hosts or hostfiles.
Signed-off-by: Ralph Castain rhc@pmix.org
(cherry picked from commit e09c049)
Preserve backward compatibility
For earlier versions of PMIx, we won't have access to
the pmix_getline utility - so preserve the static
versions of that function where required for those
earlier versions.
Signed-off-by: Ralph Castain rhc@pmix.org
(cherry picked from commit 951af44)
Check the PMIx version for min required
Need to check the PMIx version at runtime to ensure it
meets the minimum requirements. Can only do this where
supported (i.e., PMIx v4.2.7 and above).
Signed-off-by: Ralph Castain rhc@pmix.org
(cherry picked from commit eefd2b4)
Correct min version for pmix_getline util
Wasn't made globally visible until PMIx v4.2.8
Signed-off-by: Ralph Castain rhc@pmix.org
(cherry picked from commit ef54abf)