Silence a few warnings and add multi-get example #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quite a couple of warnings for use of unitialized variables. Add a "double-get" test to exercise direct modex operations Signed-off-by: Ralph Castain <rhc@pmix.org>
angainor
reviewed
Jan 9, 2020
| PMIX_VALUE_RELEASE(pvalue); | ||
|
|
||
| /* the below two lines break the subsequent PMIx_Get query on a key set later */ | ||
| pmi_set_string("test-key-1", data, 256); |
There was a problem hiding this comment.
@rhc54 If you add pmix_exchange(true); in line 131, then the pmi_get_string in line 138 fails with error -46
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quite a couple of warnings for use of unitialized variables.
Add a "double-get" test to exercise direct modex operations
Signed-off-by: Ralph Castain rhc@pmix.org