-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] OBSDOCS-833 Logging 5.9.0 Release Notes #73530
Conversation
ab5f243
to
d42b80d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit re deprecation notice.
f8abb7b
to
525d6c3
Compare
Please check if we need release notes for the below 5.9 epics |
@kabirbhartiRH I have added the epics to release notes. PTAL. Thanks! |
4b057ac
to
4f84659
Compare
@shreyasiddhartha All above have 'Release Note Not required' set but also have 'Release note text' on them. |
I'm removing the above JIRAs as, if it's set to "Release Note Not required", it need not be drafted. Most of the JIRAs are clones from previous z-stream releases where "Release Note Text" was updated in the JIRA as well as the docs, hence it's showing for 5.9 JIRAs as well. Thanks for pointing this out. :) |
65aaf74
to
c3e0a2d
Compare
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing https://issues.redhat.com/browse/LOG-5165 from log storage bug fixes.
@periklis The bug has "Release Note Type" set to "Release Note Not Required". Do you still want me to cover it? It was also covered in a z-stream release. |
Yes please add this one here too. This was a small selector mistake on my side. |
New changes are detected. LGTM label has been removed. |
ec8d137
to
81cd938
Compare
@shreyasiddhartha A few nits. Otherwise LGTM |
63a55c6
to
54dab88
Compare
/label merge-review-needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some comments for changes before merging
0d6df12
to
7c596b0
Compare
@shreyasiddhartha: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
/cherrypick enterprise-4.13 |
/cherrypick enterprise-4.14 |
/cherrypick enterprise-4.15 |
/cherrypick enterprise-4.16 |
@abrennan89: new pull request created: #74237 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@abrennan89: new pull request created: #74238 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@abrennan89: new pull request created: #74239 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@abrennan89: new pull request created: #74240 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Change type: Doc update; Logging 5.9.0 Release Notes
Doc JIRA: https://issues.redhat.com/browse/OBSDOCS-833
Fix Version: 4.13+
Doc Preview: https://73530--ocpdocs-pr.netlify.app/openshift-enterprise/latest/logging/logging_release_notes/logging-5-9-release-notes
SME Review: @periklis
QE Review: @kabirbhartiRH
Peer Review: @mburke5678