Do proper error handling of strtonum #410
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daztucker
reviewed
Jul 5, 2023
AreaZR
changed the title
|
@daztucker Fixed! |
|
I've applied the cast change, but as I said above I do not see the need for the rest of this change since the existing error check is unambiguous. Can you give an example of when the existing code does the incorrect thing? |
AreaZR
force-pushed
the
UINT_MAX
branch
3 times, most recently
from
98dc593
to
556f58e
Compare
AreaZR
changed the title
|
You did not address my previous comment: " I do not see the need for the rest of this change since the existing error check is unambiguous. Can you give an example of when the existing code does the incorrect thing?" |
Checking for an error string is the proper step. Have an error string for consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking for an error string is the proper step, rather than checking for 0.
Have an error string for consistency.