-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ssh-keygen: print keyfile when reading passphrase #503
base: master
Are you sure you want to change the base?
Conversation
I think this output should only be optional, activated by a commandline-switch. |
I understand your point, but unfortunately this wouldn't solve my initial problem because I don't call ssh-keygen myself (my problem is git committing with ssh signature). Maybe this could be done using an env var instead? |
@ChrisTG742 What do you think about my suggestion? |
Sounds reasonable to me. However, it's not up to me to decide as I'm not the maintainer of this repo. |
@djmdjm I assume you're the maintainer here? Maybe you can take a look at my changes now? |
@djmdjm Sorry for mentioning you again - but could you either take a look at my changes or tell me how I should go on with this? |
Hey @djmdjm I would like to get that done. Could you review my changes? |
Hello @djmdjm please tell me what to do. It is really frustrating to see this jsut getting ignored completely. |
IMO the best solution here is to make |
@djmdjm looks like 9.9 was released now, so what's the state of this issue? |
Hey @djmdjm, what's the state here? 9.9 was released |
Hello!
When ssh-keygen needs a passphrase to decrypt a private key, it just prints the message
Enter passphrase:
.However, applications like KSSHAskPass are using this prompt to determine which key is currently being used so the correct passphrase can be requested from the password stores.
This changes the message to the one used for most other requests,
Enter passphrase for key '…':
.I never developed with C before, so if there's something that needs a change, please just comment!
Thanks!