Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix cyclic dependencies #10431

Merged
merged 1 commit into from
Sep 3, 2024
Merged

fix cyclic dependencies #10431

merged 1 commit into from
Sep 3, 2024

Conversation

k-yle
Copy link
Collaborator

@k-yle k-yle commented Aug 24, 2024

utilDisplayLabel imports presetManager which imports utils.js, causing a dependency cycle.

This PR moves utilDisplayLabel into a separate file and updates the imports.

@k-yle k-yle added the chore Improvements to the iD development experience or codebase label Aug 24, 2024
@k-yle k-yle mentioned this pull request Sep 3, 2024
Open
@tyrasd tyrasd merged commit 9990a7b into develop Sep 3, 2024
4 checks passed
@tyrasd tyrasd deleted the kh/dep-cycle branch September 3, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyrasd tyrasd tyrasd approved these changes

Assignees
No one assigned
Labels
chore Improvements to the iD development experience or codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@k-yle @tyrasd