TL/UCP: Grace tuning #1027
Open
TL/UCP: Grace tuning #1027
+83
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samnordmann
approved these changes
Oct 3, 2024
nsarka
force-pushed
the
nsarka/tl_ucp_static_tuning
branch
2 times, most recently
from
ec27773
to
5c9e288
Compare
nsarka
commented
Oct 4, 2024
| sec_h = &sec->vals_h; | ||
| j = kh_get(ucc_sec, sec_h, tune_key); | ||
| if (j != kh_end(sec_h)) { | ||
| *tuning_str = kh_val(sec_h, j); | ||
| } | ||
| status = ucc_apply_file_cfg(team_cfg, tl_fields, env_prefix, | ||
| component_prefix, sec_name); | ||
| return status; | ||
| found = 1; |
There was a problem hiding this comment.
This is to allow the conf file to match multiple sections and take whatever section is matched last. The idea is that in the conf, the sections can be sorted from generic to specific going from top of the file to bottom. This allows a generic Grace config in case the more specific configs don't match (e.g. a team with 2 sockets 70 procs/socket won't match the 2 sockets 72 procs/socket config, so fall back to the generic config)
nsarka
force-pushed
the
nsarka/tl_ucp_static_tuning
branch
from
cf702c7
to
e1152ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates UCC to allow a socket range in ucc.conf in addition to vendor/arch/nodes/ppn and uses it to tune TL/UCP for Grace systems.