-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add config file for cmake to find UCC on system #255
Conversation
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls add copyright to new files
cmake/ucc-config-version.cmake.in
Outdated
if (PACKAGE_FIND_VERSION_RANGE) | ||
# Package version must be in the requested version range | ||
if ((PACKAGE_FIND_VERSION_RANGE_MIN STREQUAL "INCLUDE" AND PACKAGE_VERSION VERSION_LESS PACKAGE_FIND_VERSION_MIN) | ||
OR ((PACKAGE_FIND_VERSION_RANGE_MAX STREQUAL "INCLUDE" AND PACKAGE_VERSION VERSION_GREATER PACKAGE_FIND_VERSION_MAX) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove extra parenthesis
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
I have added copyright info, I also updated the commit title. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zasdfgbnm-nvidia thanks for the PR. I have a couple of minor comments:
- Can we support project name with capital letters? Currently when i need to set custom search path i'm setting -Ducc_DIR= which kind of looks unorthodox. I'd prefer it be: UCC_DIR.
- Why cmake-* files go under install/lib? Is it common? Wouldn't it be more natural to put it, e.g., in "install/share" ?
Re @vspetrov
For another example see: https://github.com/nih-at/libzip/blob/master/CMakeLists.txt#L442 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, looks good
@zasdfgbnm please rebase |
@vspetrov rebased |
This PR makes the installation script writes cmake config files to
${prefix}/lib/cmake/ucc
so that cmake projects can easily find UCC installed on the system. PyTorch uses cmake, so this will be helpful for PyTorch to integrate the ucc backend to upstream.I will add the same thing for UCX later. This PR is tested by: https://github.com/zasdfgbnm/cmake-ucx-ucc, please let me know if you want cmake testes to be included in this repository as well.