Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UCT/IB/RC: Add resource query and setup infrastructure. #14

Merged
merged 3 commits into from
Nov 4, 2014

Conversation

yosefe
Copy link
Contributor

@yosefe yosefe commented Nov 3, 2014

This one defines a framework for getting communication resources, and creating interface. An implementation over IB/RC is also included.
Hardware resources are identified by a string, e.g "mlx4_0:1", or "memory". The returned list is of all supported combinations of transports and resources.
The subnet address field is intended to provide "proximity"/"connectivity" information to upper level/user. It could be IB subnet prefix, or an IPv4/v6 subnet prefix, or in case of shared memory - unique host ID. The rule is, if you have an interface created on one resource, it could talk to any interface created on a remote resource, provided they have the same subnet address. This of course does not deal with cluster mis-configuration issues.

* Add API functions to query for resources
* Implement resource query for IB transports/devices
* Add RC transport
*/
typedef struct uct_resource_desc {
char tl_name[64]; /* Transport name */
char hw_name[64]; /* Hardware resource name */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to change 64 to:
#define UCT_MAX_NAME_LEN (64)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@shamisp
Copy link
Contributor

shamisp commented Nov 3, 2014

Done with the first pass

@shamisp
Copy link
Contributor

shamisp commented Nov 3, 2014

@fullerdj you may want to review it as well (if you have time)

* Define constatnt for name length.
* Fallback if HCA locality file is not present
* Single return point for uct_ib_query_resources
@mellanox-github
Copy link
Contributor

Merged build triggered.

@mellanox-github
Copy link
Contributor

Merged build started.

@mellanox-github
Copy link
Contributor

Merged build finished. Test FAILed.

@mellanox-github
Copy link
Contributor

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
http://bgate.mellanox.com:8000/jenkins-secure/job/ucx-PR/12/

Build Log
last 50 lines

GitHub pull request #14 of commit 2e60f9988ee06292df7d897f9138e1a19de0018b automatically merged.
[EnvInject] - Loading node environment variables.
Building in workspace /var/lib/jenkins/jobs/ucx-PR/workspace@2

Deleting project workspace... done

Wiping out workspace first.
Cloning the remote Git repository
Cloning repository https://github.com/uccs/ucx
 > /usr/bin/git init /var/lib/jenkins/jobs/ucx-PR/workspace@2 # timeout=10
Fetching upstream changes from https://github.com/uccs/ucx
 > /usr/bin/git --version # timeout=10
using .gitcredentials to set credentials
 > /usr/bin/git config --local credential.helper store --file=/tmp/git5222726624637438966.credentials # timeout=10
 > /usr/bin/git fetch --tags --progress https://github.com/uccs/ucx +refs/heads/*:refs/remotes/origin/* # timeout=60
 > /usr/bin/git config --local --remove-section credential # timeout=10
 > /usr/bin/git config remote.origin.url https://github.com/uccs/ucx # timeout=10
 > /usr/bin/git config remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10
 > /usr/bin/git config remote.origin.url https://github.com/uccs/ucx # timeout=10
Pruning obsolete local branches
Fetching upstream changes from https://github.com/uccs/ucx
using .gitcredentials to set credentials
 > /usr/bin/git config --local credential.helper store --file=/tmp/git3811109769781194601.credentials # timeout=10
 > /usr/bin/git fetch --tags --progress https://github.com/uccs/ucx +refs/pull/*:refs/remotes/origin/pr/* --prune # timeout=60
 > /usr/bin/git config --local --remove-section credential # timeout=10
 > /usr/bin/git rev-parse origin/pr/14/merge^{commit} # timeout=10
Checking out Revision b27280ee952a9fc7ebd56a35767bca1cfb3f7aaa (detached)
 > /usr/bin/git config core.sparsecheckout # timeout=10
 > /usr/bin/git checkout -f b27280ee952a9fc7ebd56a35767bca1cfb3f7aaa # timeout=20
Using 'Changelog to branch' strategy.
Triggering ucx-PR » master
ucx-PR » master completed with result FAILURE

Test FAILed.

@shamisp
Copy link
Contributor

shamisp commented Nov 4, 2014

The above error seems to be installation problem.

@shamisp
Copy link
Contributor

shamisp commented Nov 4, 2014

👍

yosefe added a commit that referenced this pull request Nov 4, 2014
UCT/IB/RC: Add resource query and setup infrastructure.
@yosefe yosefe merged commit 98ca1b0 into openucx:master Nov 4, 2014
@yosefe yosefe deleted the topic/ib-setup branch November 4, 2014 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants