Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UCP/TAG: Use hash table for matching unexpected receive descriptors. #1520

Merged
merged 4 commits into from
May 19, 2017
Merged

UCP/TAG: Use hash table for matching unexpected receive descriptors. #1520

merged 4 commits into from
May 19, 2017

Conversation

yosefe
Copy link
Contributor

@yosefe yosefe commented May 16, 2017

No description provided.

@yosefe yosefe modified the milestone: v1.3 May 16, 2017
@yosefe yosefe added the Optimization Code / performance optimization label May 16, 2017
@mellanox-github
Copy link
Contributor

Test PASSed.
See http://bgate.mellanox.com/jenkins/job/gh-ucx-pr/1673/ for details.

@mellanox-github
Copy link
Contributor

Test PASSed.
See http://hpc-master.lab.mtl.com:8080/job/hpc-ucx-pr/3604/ for details (Mellanox internal link).

@yosefe
Copy link
Contributor Author

yosefe commented May 17, 2017

@brminich pls take a look

brminich
brminich reviewed May 17, 2017
View reviewed changes
Copy link
Contributor

@brminich brminich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should not unexpected timing be updated in scalability test now?

src/ucp/tag/tag_recv.c
ucp_tag_exp_add(&worker->context->tm, req);
ucs_trace_req("%s returning expected request %p (%p)", debug_name,
req, req + 1);
ucp_tag_exp_push(&context->tm, queue, req);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just curious: does it provide performance benefit over the old func with request?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, probably because some variables can be kept in registers

@yosefe
Copy link
Contributor Author

yosefe commented May 18, 2017

@brminich updated the test

@mellanox-github
Copy link
Contributor

Test FAILed.
See http://bgate.mellanox.com/jenkins/job/gh-ucx-pr/1687/ for details.

@mellanox-github
Copy link
Contributor

Test FAILed.
See http://bgate.mellanox.com/jenkins/job/gh-ucx-pr/1688/ for details.

@mellanox-github
Copy link
Contributor

Test FAILed.
See http://hpc-master.lab.mtl.com:8080/job/hpc-ucx-pr/3619/ for details (Mellanox internal link).

@mellanox-github
Copy link
Contributor

Test FAILed.
See http://bgate.mellanox.com/jenkins/job/gh-ucx-pr/1689/ for details.

@mellanox-github
Copy link
Contributor

Test FAILed.
See http://hpc-master.lab.mtl.com:8080/job/hpc-ucx-pr/3620/ for details (Mellanox internal link).

@mellanox-github
Copy link
Contributor

Test PASSed.
See http://bgate.mellanox.com/jenkins/job/gh-ucx-pr/1691/ for details.

@mellanox-github
Copy link
Contributor

Test PASSed.
See http://hpc-master.lab.mtl.com:8080/job/hpc-ucx-pr/3622/ for details (Mellanox internal link).

brminich
brminich approved these changes May 18, 2017
View reviewed changes
Copy link
Contributor

@brminich brminich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@yosefe yosefe merged commit 1c650ec into openucx:master May 19, 2017
@yosefe yosefe deleted the topic/ucp-tag-unexp-hash branch May 19, 2017 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brminich brminich brminich approved these changes

Assignees
No one assigned
Labels
Optimization Code / performance optimization
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@yosefe @mellanox-github @brminich