Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UCP: Add the latency.overhead to the passed address. #1544

Merged
merged 1 commit into from
May 30, 2017
Merged

UCP: Add the latency.overhead to the passed address. #1544

merged 1 commit into from
May 30, 2017

Conversation

alinask
Copy link
Contributor

@alinask alinask commented May 25, 2017

No description provided.

@alinask
Copy link
Contributor Author

alinask commented May 25, 2017

Fixes #1534

@alinask alinask changed the title UCP: Add the lanency.overhead to the passed address. UCP: Add the latency.overhead to the passed address. May 25, 2017
@alinask
Copy link
Contributor Author

alinask commented May 25, 2017

@yosefe @brminich please review.

@yosefe yosefe added the Bugfix label May 25, 2017
@mellanox-github
Copy link
Contributor

Test FAILed.
See http://bgate.mellanox.com/jenkins/job/gh-ucx-pr/1744/ for details.

@mellanox-github
Copy link
Contributor

Test FAILed.
See http://hpc-master.lab.mtl.com:8080/job/hpc-ucx-pr/3687/ for details (Mellanox internal link).

@alinask
UCP: Add the latency.overhead to the passed address.
eb7fd1b 
- Add the lanency.overhead to the passed address so that each rank can
  see the same values when selecting a lane - since this value maybe
  different for different ranks.

- Consider the remote peer's bandwidth in the rndv score function - this
  will allow support for cases where different ranks have different
  speeds on their HCAs - heterogeneous fabric.

- enhance the logging for pack/unpack address - include the priority of
  the device and the lantency overhead.

fixes openucx#1534
@alinask alinask force-pushed the topic/ucp-add-lat-ovh-to-addr branch from a82fdc5 to eb7fd1b Compare May 29, 2017 15:50
@mellanox-github
Copy link
Contributor

Test PASSed.
See http://bgate.mellanox.com/jenkins/job/gh-ucx-pr/1764/ for details.

@alinask
Copy link
Contributor Author

alinask commented May 29, 2017

@yosefe @brminich please review.

@mellanox-github
Copy link
Contributor

Test FAILed.
See http://hpc-master.lab.mtl.com:8080/job/hpc-ucx-pr/3702/ for details (Mellanox internal link).

brminich
brminich approved these changes May 29, 2017
View reviewed changes
Copy link
Contributor

@brminich brminich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mellanox-github
Copy link
Contributor

Test PASSed.
See http://hpc-master.lab.mtl.com:8080/job/hpc-ucx-pr/3706/ for details (Mellanox internal link).

@yosefe yosefe merged commit 56c783f into openucx:master May 30, 2017
@yosefe
Copy link
Contributor

yosefe commented May 30, 2017

@alinask pls port to v1.2

@MattBBaker MattBBaker mentioned this pull request May 31, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yosefe yosefe yosefe approved these changes

@brminich brminich brminich approved these changes

Assignees
No one assigned
Labels
Bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alinask @mellanox-github @yosefe @brminich