UCP: Add the latency.overhead to the passed address. #1552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add the lanency.overhead to the passed address so that each rank can see the same values when selecting a lane - since this value maybe different for different ranks. - Consider the remote peer's bandwidth in the rndv score function - this will allow support for cases where different ranks have different speeds on their HCAs - heterogeneous fabric. - enhance the logging for pack/unpack address - include the priority of the device and the lantency overhead. fixes openucx#1534 (cherry picked from commit eb7fd1b)
|
@yosefe please review. |
|
Test PASSed. |
|
Test PASSed. |
yosefe
approved these changes
May 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the lanency.overhead to the passed address so that each rank can
see the same values when selecting a lane - since this value maybe
different for different ranks.
Consider the remote peer's bandwidth in the rndv score function - this
will allow support for cases where different ranks have different
speeds on their HCAs - heterogeneous fabric.
enhance the logging for pack/unpack address - include the priority of
the device and the lantency overhead.
fixes #1534
(cherry picked from commit eb7fd1b)