Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UCM: Use correct pointer for original 'free' when patching plt. #1626

Merged
merged 1 commit into from
Jun 21, 2017
Merged

UCM: Use correct pointer for original 'free' when patching plt. #1626

merged 1 commit into from
Jun 21, 2017

Conversation

yosefe
Copy link
Contributor

@yosefe yosefe commented Jun 20, 2017 •
edited
Loading

Fixes #1533

@yosefe
UCM: Use correct pointer for original 'free' when patching plt.
6cd74df 
If using just 'free' as-is, it would point to free@plt which would jump
to ucm_free and result in infinite recursion. Instead, use whatever
free@plt was jumping to originally.
@yosefe yosefe added the Bugfix label Jun 20, 2017
@yosefe
Copy link
Contributor Author

yosefe commented Jun 20, 2017

@shamisp @brminich pls review

@swx-jenkins1
Copy link

Test PASSed.
See http://bgate.mellanox.com/jenkins/job/gh-ucx-pr/1934/ for details.

@mellanox-github
Copy link
Contributor

Test FAILed.
See http://hpc-master.lab.mtl.com:8080/job/hpc-ucx-pr/3904/ for details (Mellanox internal link).

@mellanox-github
Copy link
Contributor

Test PASSed.
See http://hpc-master.lab.mtl.com:8080/job/hpc-ucx-pr/3907/ for details (Mellanox internal link).

brminich
brminich approved these changes Jun 20, 2017
View reviewed changes
Copy link
Contributor

@brminich brminich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@yosefe yosefe merged commit 022f9b1 into openucx:master Jun 21, 2017
@yosefe yosefe deleted the topic/ucm-fix-orig-free branch June 25, 2017 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brminich brminich brminich approved these changes

Assignees
No one assigned
Labels
Bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yosefe @swx-jenkins1 @mellanox-github @brminich