make mpool.h installable #1901
Merged
make mpool.h installable #1901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test PASSed. |
|
Test PASSed. |
|
can you please wrap it with |
yosefe
reviewed
Oct 11, 2017
src/ucs/datastruct/mpool.h
Outdated
|
|
||
| #include <ucs/debug/log.h> | ||
| #include <ucs/debug/memtrack.h> | ||
| #include <stdlib.h> |
src/ucs/datastruct/mpool.inl
Outdated
| @@ -9,6 +9,7 @@ | |||
|
|
|||
| #include "mpool.h" | |||
|
|
|||
| #include <ucs/debug/log.h> | |||
There was a problem hiding this comment.
need to be <ucs/config/global_opts.h> instead
|
@miked-mellanox no need - mpool.h does not include config.h |
|
Test PASSed. |
|
👍 |
shamisp
approved these changes
Oct 11, 2017
yosefe
approved these changes
Oct 11, 2017
|
Test FAILed. |
|
@yosefe - what is the failure ? |
|
Test PASSed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is meant to make mpool.h installable. It is a follow up on #1649.
I am using it for some work in OpenSHMEM.