-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UCX: backports from 1.3/master #1991
Conversation
hoopoepg
commented
Nov 12, 2017
- backports of some fixes
Build finished. |
Test PASSed. |
Test FAILed. |
bot:mlx:retest |
Test FAILed. |
bot:mlx:retest |
Test PASSed. |
src/ucp/api/ucp_compat.h
Outdated
* @ingroup UCP_ENDPOINT | ||
* @deprecated Replaced by @ref ucp_ep_close_nb. | ||
*/ | ||
ucs_status_ptr_t ucp_disconnect_nb(ucp_ep_h ep); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why need to add functions to compat.h? should be just adding C wrapper..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
really strange... when I cherry-pick this commit git displayed that there was indentation change only, no new lines.
I rebased commit again
eaa7b2a
to
748634f
Compare
- fixed crash on ARM (actually on other platofrms too, but due to data align it was hided) - changed statistics node definition: added placeholder for counter to suppress compilation error by clang fix for issue openucx#1784
- there was incorrect processing of zero-length EP address which is true for DC transport
- fixed potential issue reported by gcc 7.1.1 - added configuration scripts to skip tests on malloc state API is unavailable
- this device is used on VM where SRIOV is configured
- added device vendor ID 4116 to known device list (VMs) - this is part of fix for Redmine #1168469
- added 'extern "C"' wrapper around public functions definitions
748634f
to
808406b
Compare
@yosefe not sure where from additional funcs are come. I just rebased commit "external C" and it gone |
Build finished. |
Test PASSed. |
Test PASSed. |
Build finished. |
Test FAILed. |
Test PASSed. |