Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UCP/TAG: Fix RNDV get_zcopy progression #2097

Merged
merged 1 commit into from
Dec 21, 2017

Conversation

brminich
Copy link
Contributor

Fixes #2056

@swx-jenkins1
Copy link

Test PASSed.
See http://bgate.mellanox.com/jenkins/job/gh-ucx-pr/3428/ for details.

@jenkinsornl
Copy link

Build finished.

@mellanox-github
Copy link
Contributor

Test PASSed.
See http://hpc-master.lab.mtl.com:8080/job/hpc-ucx-pr/5569/ for details (Mellanox internal link).

@@ -406,10 +406,11 @@ UCS_PROFILE_FUNC(ucs_status_t, ucp_proto_progress_rndv_get_zcopy, (self),
if (rndv_req->send.state.uct_comp.count == 0) {
ucp_rndv_complete_rndv_get(rndv_req);
}
return UCS_OK;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yosefe
Copy link
Contributor

yosefe commented Dec 20, 2017

what happened, unexpected rndv was not removed and matched again as expected by the offload?

@yosefe yosefe added the Bugfix label Dec 20, 2017
@yosefe yosefe merged commit aa523d7 into openucx:master Dec 21, 2017
@brminich brminich deleted the topic/ucp_fix_get_rndv branch December 21, 2017 06:19
@brminich
Copy link
Contributor Author

The fault appeared due to duplicate ATS was received in a row.

@yosefe
Copy link
Contributor

yosefe commented Dec 21, 2017

bug introduced by #1981

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants