Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing multiple build issues on non-mlnx systems #21

Merged
merged 1 commit into from
Nov 11, 2014

Conversation

shamisp
Copy link
Contributor

@shamisp shamisp commented Nov 10, 2014

  • Autotools scripts were updated
  • Fixing multiple warnings in gtests
  • Other minor issue

@shamisp
Copy link
Contributor Author

shamisp commented Nov 10, 2014

Please review and test on your systems.

@mellanox-github
Copy link
Contributor

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
http://bgate.mellanox.com:8000/jenkins-secure/job/gh-ucx-pr/28/

Build Log
last 50 lines

[...truncated 1279 lines...]
rm -f *.lo
make[1]: Leaving directory `/scrap/jenkins/jobs/gh-ucx-pr/workspace/src/uct'
Making clean in test/perf
make[1]: Entering directory `/scrap/jenkins/jobs/gh-ucx-pr/workspace/test/perf'
 rm -f ucx_perftest
rm -rf .libs _libs
rm -f *.o
rm -f *.lo
make[1]: Leaving directory `/scrap/jenkins/jobs/gh-ucx-pr/workspace/test/perf'
make[1]: Entering directory `/scrap/jenkins/jobs/gh-ucx-pr/workspace'
rm -rf .libs _libs
rm -f *.lo
make[1]: Leaving directory `/scrap/jenkins/jobs/gh-ucx-pr/workspace'
+ ./contrib/configure-devel
./contrib/test_jenkins.sh: line 27: ./contrib/configure-devel: Permission denied
+ echo 'Starting gtest'
Starting gtest
+ make -C test/gtest test
make: Entering directory `/scrap/jenkins/jobs/gh-ucx-pr/workspace/test/gtest'
make -C ../../src/uct
make[1]: Entering directory `/scrap/jenkins/jobs/gh-ucx-pr/workspace/src/uct'
  CC       tl/libuct_la-context.lo
  CC       ib/base/libuct_la-ib_context.lo
  CC       ib/base/libuct_la-ib_device.lo
  CC       ib/base/libuct_la-ib_iface.lo
  CC       ib/mlx5/libuct_la-ib_mlx5.lo
  CC       ib/rc/libuct_la-rc_ep.lo
  CC       ib/rc/libuct_la-rc_iface.lo
  CC       ib/rc/libuct_la-rc_mlx5.lo
make[1]: *** No rule to make target `../ucs/libucs.la', needed by `libuct.la'.  Stop.
make[1]: Leaving directory `/scrap/jenkins/jobs/gh-ucx-pr/workspace/src/uct'
make: *** [uct] Error 2
make: Leaving directory `/scrap/jenkins/jobs/gh-ucx-pr/workspace/test/gtest'
Build step 'Execute shell' marked build as failure
TAP Reports Processing: START
Looking for TAP results report in workspace using pattern: **/*.tap
Did not find any matching files.
[Valgrind] Files to copy:
[Valgrind] Analysing valgrind results
[Valgrind] Ending the valgrind analysis.
Anchor chain: could not read file with links: /var/lib/jenkins/jobs/gh-ucx-pr/workspace/jenkins_sidelinks.txt (No such file or directory)
[copy-to-slave] The build is taking place on the master node, no copy back to the master will take place.
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Request made to compress build log
Sending email to: eugene@mellanox.com miked@mellanox.com yosefe@mellanox.com
[BFA] Scanning build for known causes...

[BFA] Done. 0s

Test FAILed.

@mellanox-github
Copy link
Contributor

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
http://bgate.mellanox.com:8000/jenkins-secure/job/gh-ucx-pr/29/

Build Log
last 50 lines

[...truncated 1960 lines...]
[       OK ] test_config.performance (177 ms)
[ RUN      ] test_config.dump
[       OK ] test_config.dump (21 ms)
[----------] 6 tests from test_config (286 ms total)

[----------] 1 test from test_component
[ RUN      ] test_component.init_cleanup
[       OK ] test_component.init_cleanup (8 ms)
[----------] 1 test from test_component (8 ms total)

[----------] 3 tests from test_uct
[ RUN      ] test_uct.query_resources
[     INFO ] 0: rc_mlx5 on mlx5_0:1 at 6502.32 MB/sec
[       OK ] test_uct.query_resources (204 ms)
[ RUN      ] test_uct.open_iface
[       OK ] test_uct.open_iface (72 ms)
[ RUN      ] test_uct.connect_ep
[       OK ] test_uct.connect_ep (248 ms)
[----------] 3 tests from test_uct (527 ms total)

[----------] Global test environment tear-down
[==========] 68 tests from 18 test cases ran. (80563 ms total)
[  PASSED  ] 66 tests.
[  FAILED  ] 2 tests, listed below:
[  FAILED  ] test_datatype.queue_perf
[  FAILED  ] test_datatype.ptr_array_perf

 2 FAILED TESTS
make: *** [test_valgrind] Error 1
make: Leaving directory `/scrap/jenkins/jobs/gh-ucx-pr/workspace/test/gtest'
Build step 'Execute shell' marked build as failure
TAP Reports Processing: START
Looking for TAP results report in workspace using pattern: **/*.tap
Did not find any matching files.
[Valgrind] Files to copy:
[Valgrind] test/gtest/valgrind.xml
[Valgrind] Copying test/gtest/valgrind.xml to /var/lib/jenkins/jobs/gh-ucx-pr/builds/2014-11-11_00-10-57/valgrind-plugin/valgrind-results/test/gtest/valgrind.xml
[Valgrind] Analysing valgrind results
[Valgrind] workspacePath: /var/lib/jenkins/jobs/gh-ucx-pr/workspace/
[Valgrind] Ending the valgrind analysis.
Anchor chain: could not read file with links: /var/lib/jenkins/jobs/gh-ucx-pr/workspace/jenkins_sidelinks.txt (No such file or directory)
[copy-to-slave] The build is taking place on the master node, no copy back to the master will take place.
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Request made to compress build log
Sending email to: eugene@mellanox.com miked@mellanox.com yosefe@mellanox.com
[BFA] Scanning build for known causes...

[BFA] Done. 0s

Test FAILed.

@shamisp
Copy link
Contributor Author

shamisp commented Nov 10, 2014

I don't think these tests are already available on master:
[ FAILED ] 2 tests, listed below:
[ FAILED ] test_datatype.queue_perf
[ FAILED ] test_datatype.ptr_array_perf

It is part of #20

@mellanox-github
Copy link
Contributor

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
http://bgate.mellanox.com:8000/jenkins-secure/job/gh-ucx-pr/30/

Build Log
last 50 lines

[...truncated 1960 lines...]
[       OK ] test_config.performance (177 ms)
[ RUN      ] test_config.dump
[       OK ] test_config.dump (22 ms)
[----------] 6 tests from test_config (285 ms total)

[----------] 1 test from test_component
[ RUN      ] test_component.init_cleanup
[       OK ] test_component.init_cleanup (7 ms)
[----------] 1 test from test_component (8 ms total)

[----------] 3 tests from test_uct
[ RUN      ] test_uct.query_resources
[     INFO ] 0: rc_mlx5 on mlx5_0:1 at 6502.32 MB/sec
[       OK ] test_uct.query_resources (204 ms)
[ RUN      ] test_uct.open_iface
[       OK ] test_uct.open_iface (71 ms)
[ RUN      ] test_uct.connect_ep
[       OK ] test_uct.connect_ep (250 ms)
[----------] 3 tests from test_uct (528 ms total)

[----------] Global test environment tear-down
[==========] 68 tests from 18 test cases ran. (79379 ms total)
[  PASSED  ] 66 tests.
[  FAILED  ] 2 tests, listed below:
[  FAILED  ] test_datatype.queue_perf
[  FAILED  ] test_datatype.ptr_array_perf

 2 FAILED TESTS
make: *** [test_valgrind] Error 1
make: Leaving directory `/scrap/jenkins/jobs/gh-ucx-pr/workspace/test/gtest'
Build step 'Execute shell' marked build as failure
TAP Reports Processing: START
Looking for TAP results report in workspace using pattern: **/*.tap
Did not find any matching files.
[Valgrind] Files to copy:
[Valgrind] test/gtest/valgrind.xml
[Valgrind] Copying test/gtest/valgrind.xml to /var/lib/jenkins/jobs/gh-ucx-pr/builds/2014-11-11_01-45-58/valgrind-plugin/valgrind-results/test/gtest/valgrind.xml
[Valgrind] Analysing valgrind results
[Valgrind] workspacePath: /var/lib/jenkins/jobs/gh-ucx-pr/workspace/
[Valgrind] Ending the valgrind analysis.
Anchor chain: could not read file with links: /var/lib/jenkins/jobs/gh-ucx-pr/workspace/jenkins_sidelinks.txt (No such file or directory)
[copy-to-slave] The build is taking place on the master node, no copy back to the master will take place.
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Request made to compress build log
Sending email to: eugene@mellanox.com miked@mellanox.com yosefe@mellanox.com
[BFA] Scanning build for known causes...

[BFA] Done. 0s

Test FAILed.

@mellanox-github
Copy link
Contributor

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
http://bgate.mellanox.com:8000/jenkins-secure/job/gh-ucx-pr/31/

Build Log
last 50 lines

[...truncated 1960 lines...]
[       OK ] test_config.performance (176 ms)
[ RUN      ] test_config.dump
[       OK ] test_config.dump (22 ms)
[----------] 6 tests from test_config (284 ms total)

[----------] 1 test from test_component
[ RUN      ] test_component.init_cleanup
[       OK ] test_component.init_cleanup (7 ms)
[----------] 1 test from test_component (7 ms total)

[----------] 3 tests from test_uct
[ RUN      ] test_uct.query_resources
[     INFO ] 0: rc_mlx5 on mlx5_0:1 at 6502.32 MB/sec
[       OK ] test_uct.query_resources (205 ms)
[ RUN      ] test_uct.open_iface
[       OK ] test_uct.open_iface (77 ms)
[ RUN      ] test_uct.connect_ep
[       OK ] test_uct.connect_ep (251 ms)
[----------] 3 tests from test_uct (533 ms total)

[----------] Global test environment tear-down
[==========] 68 tests from 18 test cases ran. (79907 ms total)
[  PASSED  ] 66 tests.
[  FAILED  ] 2 tests, listed below:
[  FAILED  ] test_datatype.queue_perf
[  FAILED  ] test_datatype.ptr_array_perf

 2 FAILED TESTS
make: *** [test_valgrind] Error 1
make: Leaving directory `/scrap/jenkins/jobs/gh-ucx-pr/workspace/test/gtest'
Build step 'Execute shell' marked build as failure
TAP Reports Processing: START
Looking for TAP results report in workspace using pattern: **/*.tap
Did not find any matching files.
[Valgrind] Files to copy:
[Valgrind] test/gtest/valgrind.xml
[Valgrind] Copying test/gtest/valgrind.xml to /var/lib/jenkins/jobs/gh-ucx-pr/builds/2014-11-11_02-00-58/valgrind-plugin/valgrind-results/test/gtest/valgrind.xml
[Valgrind] Analysing valgrind results
[Valgrind] workspacePath: /var/lib/jenkins/jobs/gh-ucx-pr/workspace/
[Valgrind] Ending the valgrind analysis.
Anchor chain: could not read file with links: /var/lib/jenkins/jobs/gh-ucx-pr/workspace/jenkins_sidelinks.txt (No such file or directory)
[copy-to-slave] The build is taking place on the master node, no copy back to the master will take place.
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Request made to compress build log
Sending email to: eugene@mellanox.com miked@mellanox.com yosefe@mellanox.com
[BFA] Scanning build for known causes...

[BFA] Done. 0s

Test FAILed.

@shamisp
Copy link
Contributor Author

shamisp commented Nov 11, 2014

@yosefe - I think I addressed all you comment.

In the last commit I add "HAVE_CONFIG_H" everywhere BUT since it is must to have, I think we have to remove the protection everywhere. The config.h file is not optional.

@mellanox-github
Copy link
Contributor

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
http://bgate.mellanox.com:8000/jenkins-secure/job/gh-ucx-pr/32/

Build Log
last 50 lines

[...truncated 1960 lines...]
[       OK ] test_config.performance (177 ms)
[ RUN      ] test_config.dump
[       OK ] test_config.dump (21 ms)
[----------] 6 tests from test_config (285 ms total)

[----------] 1 test from test_component
[ RUN      ] test_component.init_cleanup
[       OK ] test_component.init_cleanup (8 ms)
[----------] 1 test from test_component (8 ms total)

[----------] 3 tests from test_uct
[ RUN      ] test_uct.query_resources
[     INFO ] 0: rc_mlx5 on mlx5_0:1 at 6502.32 MB/sec
[       OK ] test_uct.query_resources (204 ms)
[ RUN      ] test_uct.open_iface
[       OK ] test_uct.open_iface (72 ms)
[ RUN      ] test_uct.connect_ep
[       OK ] test_uct.connect_ep (255 ms)
[----------] 3 tests from test_uct (533 ms total)

[----------] Global test environment tear-down
[==========] 68 tests from 18 test cases ran. (78782 ms total)
[  PASSED  ] 66 tests.
[  FAILED  ] 2 tests, listed below:
[  FAILED  ] test_datatype.queue_perf
[  FAILED  ] test_datatype.ptr_array_perf

 2 FAILED TESTS
make: *** [test_valgrind] Error 1
make: Leaving directory `/scrap/jenkins/jobs/gh-ucx-pr/workspace/test/gtest'
Build step 'Execute shell' marked build as failure
TAP Reports Processing: START
Looking for TAP results report in workspace using pattern: **/*.tap
Did not find any matching files.
[Valgrind] Files to copy:
[Valgrind] test/gtest/valgrind.xml
[Valgrind] Copying test/gtest/valgrind.xml to /var/lib/jenkins/jobs/gh-ucx-pr/builds/2014-11-11_02-10-58/valgrind-plugin/valgrind-results/test/gtest/valgrind.xml
[Valgrind] Analysing valgrind results
[Valgrind] workspacePath: /var/lib/jenkins/jobs/gh-ucx-pr/workspace/
[Valgrind] Ending the valgrind analysis.
Anchor chain: could not read file with links: /var/lib/jenkins/jobs/gh-ucx-pr/workspace/jenkins_sidelinks.txt (No such file or directory)
[copy-to-slave] The build is taking place on the master node, no copy back to the master will take place.
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Request made to compress build log
Sending email to: eugene@mellanox.com miked@mellanox.com yosefe@mellanox.com
[BFA] Scanning build for known causes...

[BFA] Done. 0s

Test FAILed.

@mellanox-github
Copy link
Contributor

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://bgate.mellanox.com:8000/jenkins-secure/job/gh-ucx-pr/33/
Test PASSed.

@@ -1,7 +1,7 @@
#!/bin/sh
#
# Copyright (C) Mellanox Technologies Ltd. 2001-2011. ALL RIGHTS RESERVED.
#
# Copyright (c) 2014 Copyright (c) UT-Battelle, LLC. 2014. ALL RIGHTS RESERVED.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is noise. I will revert copy of this file to "master" version

@mellanox-github
Copy link
Contributor

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://bgate.mellanox.com:8000/jenkins-secure/job/gh-ucx-pr/34/
Test PASSed.

@mellanox-github
Copy link
Contributor

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://bgate.mellanox.com:8000/jenkins-secure/job/gh-ucx-pr/35/
Test PASSed.

@yosefe
Copy link
Contributor

yosefe commented Nov 11, 2014

👍

* Autotools scripts were updated
* Fixing multiple warnings in gtests
* Other minor issue
* Making the code config.h compliant
@mellanox-github
Copy link
Contributor

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://bgate.mellanox.com:8000/jenkins-secure/job/gh-ucx-pr/36/
Test PASSed.

@shamisp
Copy link
Contributor Author

shamisp commented Nov 11, 2014

@yosefe @mellanox-github

On my system I see the following Failure:

----------] 4 tests from test_timer, where TypeParam =
[ RUN      ] test_timer.time_calc
[       OK ] test_timer.time_calc (0 ms)   
[ RUN      ] test_timer.get_time
/ccs/home/pavel/work/ucx/contrib/../test/gtest/ucs/test_timer.cc:63: Failure
Expected: (nsec) < (20.0), actual: 28.2012 vs 20
ucs_get_time() performance is too bad
[  FAILED  ] test_timer.get_time, where TypeParam =  and GetParam() =  (1000 ms)
[ RUN      ] test_timer.time_shift
[     INFO ] Short time shift is 16 bit, accuracy is 29.7891 usec
[       OK ] test_timer.time_shift (0 ms)
[ RUN      ] test_timer.timerq_basic
[       OK ] test_timer.timerq_basic (47 ms)
[----------] 4 tests from test_timer (1047 ms total)

Is it ok ?

@shamisp
Copy link
Contributor Author

shamisp commented Nov 11, 2014

+1 from @yosefe

alinask pushed a commit to alinask/ucx that referenced this pull request Aug 20, 2020
TEST/APPS/IO_DEMO: Merge iodemo changes from openucx:master branch.
dmitrygx pushed a commit to dmitrygx/ucx that referenced this pull request Dec 1, 2021
…n-via-ep

Separate receive operations based on the Endpoint it used with
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants