Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UCM/MALLOC: Add dynamic mmap threshold #2219

Merged
merged 5 commits into from
Jan 31, 2018
Merged

UCM/MALLOC: Add dynamic mmap threshold #2219

merged 5 commits into from
Jan 31, 2018

Conversation

yosefe
Copy link
Contributor

@yosefe yosefe commented Jan 26, 2018

No description provided.

@yosefe
UCM/MALLOC: Add dynamic mmap threshold
549ad9b 
Recent glibc() versions added optimization to dynamically adjust the
threshold for mmap and trim. Employ the same strategy in our malloc
hooks to avoid a performance degradation caused by replacing the glibc
allocators.
@yosefe yosefe added the Optimization Code / performance optimization label Jan 26, 2018
@swx-jenkins1
Copy link

Test FAILed.
See http://bgate.mellanox.com/jenkins/job/gh-ucx-pr/3815/ for details.

@mellanox-github
Copy link
Contributor

Test FAILed.
See http://hpc-master.lab.mtl.com:8080/job/hpc-ucx-pr/6015/ for details (Mellanox internal link).

@swx-jenkins1
Copy link

Test PASSed.
See http://bgate.mellanox.com/jenkins/job/gh-ucx-pr/3816/ for details.

@yosefe yosefe force-pushed the topic/ucm-dynamic-mmap-thresh branch from 86df45c to 5e6c550 Compare January 26, 2018 23:53
@mellanox-github
Copy link
Contributor

Test FAILed.
See http://hpc-master.lab.mtl.com:8080/job/hpc-ucx-pr/6016/ for details (Mellanox internal link).

@swx-jenkins1
Copy link

Test PASSed.
See http://bgate.mellanox.com/jenkins/job/gh-ucx-pr/3817/ for details.

@mellanox-github
Copy link
Contributor

Test PASSed.
See http://hpc-master.lab.mtl.com:8080/job/hpc-ucx-pr/6017/ for details (Mellanox internal link).

@yosefe
Copy link
Contributor Author

yosefe commented Jan 28, 2018

@alex-mikheev pls take a look

alex-mikheev
alex-mikheev suggested changes Jan 28, 2018
View reviewed changes
Copy link
Contributor

@alex-mikheev alex-mikheev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls add a unit test

@swx-jenkins1
Copy link

Test PASSed.
See http://bgate.mellanox.com/jenkins/job/gh-ucx-pr/3829/ for details.

@mellanox-github
Copy link
Contributor

Test FAILed.
See http://hpc-master.lab.mtl.com:8080/job/hpc-ucx-pr/6029/ for details (Mellanox internal link).

@yosefe
Copy link
Contributor Author

yosefe commented Jan 29, 2018

bot:mlx:retest

@mellanox-github
Copy link
Contributor

Test FAILed.
See http://hpc-master.lab.mtl.com:8080/job/hpc-ucx-pr/6038/ for details (Mellanox internal link).

@swx-jenkins1
Copy link

Test PASSed.
See http://bgate.mellanox.com/jenkins/job/gh-ucx-pr/3839/ for details.

@mellanox-github
Copy link
Contributor

Test FAILed.
See http://hpc-master.lab.mtl.com:8080/job/hpc-ucx-pr/6046/ for details (Mellanox internal link).

@mellanox-github
Copy link
Contributor

Test FAILed.
See http://hpc-master.lab.mtl.com:8080/job/hpc-ucx-pr/6049/ for details (Mellanox internal link).

@yosefe
Copy link
Contributor Author

yosefe commented Jan 30, 2018

bot:mlx:retest

@mellanox-github
Copy link
Contributor

Test PASSed.
See http://hpc-master.lab.mtl.com:8080/job/hpc-ucx-pr/6054/ for details (Mellanox internal link).

@yosefe
Copy link
Contributor Author

yosefe commented Jan 30, 2018

@alex-mikheev added unit test

alex-mikheev
alex-mikheev approved these changes Jan 31, 2018
View reviewed changes
Copy link
Contributor

@alex-mikheev alex-mikheev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@yosefe yosefe merged commit f4d09d0 into openucx:master Jan 31, 2018
@yosefe yosefe deleted the topic/ucm-dynamic-mmap-thresh branch January 31, 2018 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-mikheev alex-mikheev alex-mikheev approved these changes

Assignees
No one assigned
Labels
Optimization Code / performance optimization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yosefe @swx-jenkins1 @mellanox-github @alex-mikheev