UCT/IB/MLX5: Move QP to RESET (instead of error) before cleaning the SRQ - v1.3.x #2428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moving QP to error state does not guarantee all CQEs for inprogress receives would be generated when the modify_qp command completes. In order to have such guarantee, need to move the QP to reset state. However, calling ibv_modify_qp() will go to mlx5 driver which may try to cleanup those CQEs, which will mess up the linked list. Instead, we call ibv_cmd_modify_qp() directly which will just modify the QP without any cleaup actions.
yosefe
changed the title
brminich
approved these changes
Mar 20, 2018
|
Test PASSed. |
|
Test PASSed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picked from #2413