UCT/RC/DC: Fix iface tx ops buffer overflow - v1.5.x #3188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use separate memory pool for flush operations with completions to avoid iface tx ops buffer overflow.
|
Test PASSed. |
|
Test PASSed. |
yosefe
approved these changes
Feb 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix for iface tx ops buffer overflow.
Why ?
RC iface allocates buffer for tx op completions, which is used by zcopy and flush operations.
While max number of simultaneous zcopy operations is limited by CQ length, flushes are not limited at all. Since iface buffer for op completions fits just CQ length elements, it can be easily overflowed.
How ?
Use separate memory pool for flush operations with non NULL completions.
NOTE: this is not a cherry-pick from #3172, because of different UCT/IB code base