Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple fixes for UCX v1.5.2 #3662

Merged
merged 7 commits into from
Jun 4, 2019

Conversation

yosefe
Copy link
Contributor

@yosefe yosefe commented Jun 3, 2019

Fixing multiple issues for redhat per https://bugzilla.redhat.com/show_bug.cgi?id=1715129

  • Static checker: memory pool allocation falures, redundant code, ucx_info alias print
  • Fixing segfault reported by Fedora when OpenMPI is compiled with UCX

@yosefe yosefe changed the title UCT/DC: Initialize qp_cap Multiple fixes for UCX v1.5.2 Jun 3, 2019
@yosefe yosefe added the Bugfix label Jun 3, 2019
@yosefe yosefe requested a review from shamisp June 3, 2019 19:01
@swx-jenkins1
Copy link

Test FAILed.
See http://bgate.mellanox.com/jenkins/job/gh-ucx-pr/7559/ for details.

@mellanox-github
Copy link
Contributor

Test FAILed.
See http://hpc-master.lab.mtl.com:8080/job/hpc-ucx-pr/10492/ for details (Mellanox internal link).

yosefe and others added 7 commits June 4, 2019 12:09
 When UCT is loaded, the static initializer adds it's configuration
tables to the global list in UCS. When UCT is unloaded, need to remove
them from that list, otherwise the list will point to invalid memory.
- there was incorrect processing of aliases of configs
@yosefe yosefe force-pushed the topic/ucx-v1.5.2-multiple-fixes branch from 20a2f9a to 0cb7b64 Compare June 4, 2019 09:26
@swx-jenkins1
Copy link

Test PASSed.
See http://bgate.mellanox.com/jenkins/job/gh-ucx-pr/7565/ for details.

@mellanox-github
Copy link
Contributor

Test PASSed.
See http://hpc-master.lab.mtl.com:8080/job/hpc-ucx-pr/10501/ for details (Mellanox internal link).

@yosefe
Copy link
Contributor Author

yosefe commented Jun 4, 2019

bot:pipe:retest

@yosefe
Copy link
Contributor Author

yosefe commented Jun 4, 2019

@brminich can you pls take a look?

}

/* print all config table, to force going over the global list in ucs */
void (*print_all_opts)(FILE*,int) = dlsym(ucs_handle,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: space after ,

@yosefe yosefe merged commit b03b274 into openucx:v1.5.x Jun 4, 2019
@yosefe yosefe deleted the topic/ucx-v1.5.2-multiple-fixes branch June 4, 2019 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants