Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UD/RC VERBS: added support of max_inline==0 - v1.5 #3677

Merged
merged 9 commits into from
Jun 10, 2019
Merged

UD/RC VERBS: added support of max_inline==0 - v1.5 #3677

merged 9 commits into from
Jun 10, 2019

Conversation

hoopoepg
Copy link
Contributor

@hoopoepg hoopoepg commented Jun 6, 2019

  • use regular SKB entry to send UD ACK messages
    (instead of inline SKB record) in case if max_inline
    is not enough
  • fixed asserts
  • fixed iface attr values on zero max_inline

Sergey Oblomov added 6 commits June 6, 2019 11:41
UD/RC VERBS: added support of max_inline==0
0c0eaa2 
- use regular SKB entry to send UD ACK messages
  (instead of inline SKB record) in case if max_inline
  is not enough
- fixed asserts
- fixed iface attr values on zero max_inline

(cherry picked from commit 26580ec)

Conflicts:
	src/uct/ib/rc/base/rc_iface.c
	src/uct/ib/rc/verbs/rc_verbs.h
	src/uct/ib/rc/verbs/rc_verbs_ep.c
	src/uct/ib/rc/verbs/rc_verbs_iface.c
UD/VERBS: fixed max_hdr_size value initialization
24db30c 
(cherry picked from commit 06120d0)
RDMACM: disables iWarp device initialization
9ce55a2 
- due to lack of support

(cherry picked from commit a7b25b6)
VERBS: updated iface caps based on max_inline value
501a126 
(cherry picked from commit e387cd1)

Conflicts:
	src/uct/ib/rc/base/rc_iface.c
GTEST: added short/bcopy send message
f2e760c 
- added short/bcopy send message call to allow some tests
  run without AM_SHORT capability

(cherry picked from commit f20b0d1)
IB/iWARP: shifted evaluation to uct_ib_device_port_check
23ad9df 
(cherry picked from commit 27f6418)
@hoopoepg hoopoepg changed the title Topic/add support max inline v1.5 UD/RC VERBS: added support of max_inline==0 - v1.5 Jun 6, 2019
@hoopoepg
Copy link
Contributor Author

hoopoepg commented Jun 6, 2019

bot:mlx:retest

@swx-jenkins1
Copy link

Test PASSed.
See http://bgate.mellanox.com/jenkins/job/gh-ucx-pr/7605/ for details.

@hoopoepg
Copy link
Contributor Author

hoopoepg commented Jun 6, 2019

@yosefe I added one more commit for gtests.

it seems jenkins configuration changed & PPC/cuda could not build

@mellanox-github
Copy link
Contributor

Test FAILed.
See http://hpc-master.lab.mtl.com:8080/job/hpc-ucx-pr/10551/ for details (Mellanox internal link).

@mellanox-github
Copy link
Contributor

Test FAILed.
See http://hpc-master.lab.mtl.com:8080/job/hpc-ucx-pr/10552/ for details (Mellanox internal link).

@swx-jenkins1
Copy link

Test PASSed.
See http://bgate.mellanox.com/jenkins/job/gh-ucx-pr/7609/ for details.

@hoopoepg hoopoepg mentioned this pull request Jun 6, 2019
Closed
@mellanox-github
Copy link
Contributor

Test FAILed.
See http://hpc-master.lab.mtl.com:8080/job/hpc-ucx-pr/10556/ for details (Mellanox internal link).

@mellanox-github
Copy link
Contributor

Test FAILed.
See http://hpc-master.lab.mtl.com:8080/job/hpc-ucx-pr/10564/ for details (Mellanox internal link).

@yosefe
Copy link
Contributor

yosefe commented Jun 8, 2019

bot:pipe:retest

@mellanox-github
Copy link
Contributor

Test FAILed.
See http://hpc-master.lab.mtl.com:8080/job/hpc-ucx-pr/10566/ for details (Mellanox internal link).

@hoopoepg
Copy link
Contributor Author

bot:retest

@yosefe
Copy link
Contributor

yosefe commented Jun 10, 2019

bot:pipe:retest

@yosefe
JENKINS: Improve module_load check - require exact name match
6b4db1b 
(cherry picked from commit 3fe7970)

Conflicts:
	contrib/test_jenkins.sh
@mellanox-github
Copy link
Contributor

Test FAILed.
See http://hpc-master.lab.mtl.com:8080/job/hpc-ucx-pr/10575/ for details (Mellanox internal link).

@hoopoepg
Copy link
Contributor Author

bot:mlx:retest

@mellanox-github
Copy link
Contributor

Test FAILed.
See http://hpc-master.lab.mtl.com:8080/job/hpc-ucx-pr/10582/ for details (Mellanox internal link).

@mellanox-github
Copy link
Contributor

Test PASSed.
See http://hpc-master.lab.mtl.com:8080/job/hpc-ucx-pr/10590/ for details (Mellanox internal link).

@swx-jenkins1
Copy link

Test FAILed.
See http://bgate.mellanox.com/jenkins/job/gh-ucx-pr/7620/ for details.

@yosefe yosefe merged commit f4e3e2b into openucx:v1.5.x Jun 10, 2019
@swx-jenkins1
Copy link

Test PASSed.
See http://bgate.mellanox.com/jenkins/job/gh-ucx-pr/7625/ for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yosefe yosefe yosefe approved these changes

@dmitrygx dmitrygx dmitrygx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hoopoepg @swx-jenkins1 @mellanox-github @yosefe @dmitrygx