UCT/IB: Fallback to ibv_create_cq() if ibv_create_cq_ex() returns ENOSYS - v1.5.x #3688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoopoepg
reviewed
Jun 11, 2019
src/uct/ib/base/ib_iface.c
Outdated
| #endif | ||
| return cq; | ||
| { | ||
| return ibv_create_cq(context, cqe, NULL, channel, comp_vector); |
There was a problem hiding this comment.
minor: why not just leave this line without { }? as I can see there is return from function if cq_ex is completed successfully or failed due to error
There was a problem hiding this comment.
like
if (cq_ex) {
return ibv_cq_ex_to_cq(cq_ex);
} else if (errno != ENOSYS) {
return NULL;
}
/* if ibv_create_cq_ex returns ENOSYS, fallback to ibv_create_cq */
#endif
return ibv_create_cq(context, cqe, NULL, channel, comp_vector);
hoopoepg
approved these changes
Jun 11, 2019
dmitrygx
approved these changes
Jun 11, 2019
hoopoepg
approved these changes
Jun 11, 2019
yosefe
changed the title
|
Test FAILed. |
|
Test PASSed. |
|
Test PASSed. |
|
Test FAILed. |
|
Test PASSed. |
|
bot:pipe:retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.