Port fixes to v1.6.x: UCM events test, client/server example #3719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The test should also register a handler for VM_UNMAPPED, to make sure ucm_test_events(VM_UNMAPPED) would really return ERR_UNSUPPORTED after munmap() is overridden. - Convert events to native events for mmap_test_installed_events(), otherwise they will be considered as not installed so testing their support will always return success, even when it should fail.
|
Test PASSed. |
|
Test FAILed. |
- Call sbrk(0) instead of nonzero offset, which can override application memory when running with valgrind
yosefe
force-pushed
the
topic/ucm-fix-event-test-when-not-installed-v1.6.x
branch
from
5ffcc80
to
bd027f1
Compare
|
Test PASSed. |
|
Test PASSed. |
Mellanox CI: PASSED on 33 workers (click for details)Note: the logs will be deleted after 26-Jun-2019
|
|
@hoopoepg can you pls review? |
hoopoepg
approved these changes
Jun 19, 2019
|
yep - i also added fixes for client_server which cause tests to fail |
yosefe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picked from #3716
Fixes #3686