Port recent bugfixes to v1.6.x and update NEWS to v1.6-rc4 #3770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The enable/disable logic was busted in quite a few places. It "almost" work with the exception that the --disable didn't really work. Since all the options are disabled by default, we didn't notice this.
- Alignment fixes - Updating default configuration options Signed-off-by: Pavel Shamis (Pasha) <pasharesearch@gmail.com>
Signed-off-by: Pavel Shamis (Pasha) <pasharesearch@gmail.com>
Replaced ifdef with if Signed-off-by: Pavel Shamis (Pasha) <pasharesearch@gmail.com>
|
Test PASSed. |
|
Test FAILed. |
On new kernels, the RDMA device name is not indicative of driver name.
|
👍 |
|
Test PASSed. |
|
Test PASSed. |
Mellanox CI: PASSED on 33 workers (click for details)Note: the logs will be deleted after 02-Jul-2019
|
brminich
approved these changes
Jun 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.