JAVA/BUILD: Fix make dist and jar install #4640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make sure temp files are not part of dist tarball (by including more specific paths in EXTRA_DIST) - Install JAR file by jardir_DATA instead of custom install rule; this way, uninstall also works. - Add "resources" to make clean
yosefe
force-pushed
the
topic/java-build-fix-make-dist-and-jar
branch
from
7894b75
to
0696876
Compare
Mellanox CI: UNKNOWN on 25 workers (click for details)Note: the logs will be deleted after 09-Jan-2020
|
|
Looks good, i thought to just use: to remove all crap in native directory, but this more robust. |
| src/main/native | ||
|
|
||
| clean-local: | ||
| -rm -rf resources |
petro-rudenko
approved these changes
Jan 2, 2020
Mellanox CI: PASSED on 25 workers (click for details)Note: the logs will be deleted after 09-Jan-2020
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
How