-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UCX/RNDV/CUDA: RNDV protocol improvements for CUDA - v1.9.x #5648
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hoopoepg, can you please take a look as well?
src/ucp/core/ucp_context.h
Outdated
@@ -61,6 +61,8 @@ typedef struct ucp_context_config { | |||
size_t seg_size; | |||
/** RNDV pipeline fragment size */ | |||
size_t rndv_frag_size; | |||
/** RNDV pipline send threshold */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pipeline
src/ucp/tag/rndv.c
Outdated
} | ||
|
||
if (ucs_popcount(lane_map) > 1) { | ||
/* remove lanes if bandwidth is too less compare to best lane */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove lanes if bandwidth is too low comparing to the best lane
rndv_rts_hdr->size); | ||
|
||
if ((rndv_mode == UCP_RNDV_MODE_PUT_ZCOPY) || | ||
UCP_MEM_IS_CUDA(rreq->recv.mem_type)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why need to check cuda here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in default UCP_RNDV_MOD_AUTO, we try to use PUT protocol for CUDA IPC case.
bot:pipe:retest |
porting #5473 from master