UCT/DC: Flush TX #5872
Merged
UCT/DC: Flush TX #5872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Artemy-Mellanox
force-pushed
the
topic/flush_cancel_nb-2
branch
from
adabd7c
to
4bfd342
Compare
|
bot:pipe:retest |
Artemy-Mellanox
force-pushed
the
topic/flush_cancel_nb-2
branch
3 times, most recently
from
446b99a
to
ffbfab3
Compare
Artemy-Mellanox
force-pushed
the
topic/flush_cancel_nb-2
branch
3 times, most recently
from
28d4fcf
to
5730fb3
Compare
Artemy-Mellanox
force-pushed
the
topic/flush_cancel_nb-2
branch
2 times, most recently
from
e1f2e7c
to
761fff7
Compare
|
bot:pipe:retest |
Artemy-Mellanox
force-pushed
the
topic/flush_cancel_nb-2
branch
2 times, most recently
from
dbcc5f2
to
4bd6789
Compare
|
bot:pipe:retest |
yosefe
reviewed
Dec 6, 2020
src/uct/ib/dc/dc_mlx5_ep.h
Outdated
Comment on lines
401
to
404
| if ((ep->flags & UCT_DC_MLX5_EP_FLAG_FLUSH_CANCEL) && | ||
| !(ep->flags & UCT_DC_MLX5_EP_FLAG_NO_ERR_HANDLER)) { | ||
| uct_dc_mlx5_iface_reset_dci(iface, dci); | ||
| } |
There was a problem hiding this comment.
check why needed + add comment (or remove)
yosefe
reviewed
Dec 8, 2020
|
bot:pipe:retest |
yosefe
approved these changes
Dec 15, 2020
|
bot:pipe:retest |
|
@Artemy-Mellanox pls squash |
Artemy-Mellanox
force-pushed
the
topic/flush_cancel_nb-2
branch
from
6fdb7eb
to
b609ad1
Compare
|
bot:pipe:retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.