UCP/API: Add recv_info to ucp_request_param_t #5919
Conversation
src/ucp/api/ucp.h
Outdated
| * in case of immediate completion of receive operation. | ||
| */ | ||
| union { | ||
| size_t *length; |
There was a problem hiding this comment.
Do we need uint32_t mask here to show which fields were set by UCP?
e.g. I'd not expect that tag is updated by UCP AM API, but a user could specify it (e.g. user shares the same request params for TAG and AM operations)
There was a problem hiding this comment.
i do not think so. This is somewhat similar to cb field of this struct
|
@yosefe, @shamisp, @tonycurtis, can you please take a look? |
src/ucp/api/ucp.h
Outdated
| * in case of immediate completion of receive operation. | ||
| */ | ||
| union { | ||
| size_t *length; |
There was a problem hiding this comment.
Can you please add description for each one of the fields. I guess user has to allocate the memory and then it is updated in function return ?
src/ucp/api/ucp.h
Outdated
| */ | ||
| union { | ||
| size_t *length; | ||
| ucp_tag_recv_info_t *tag; |
There was a problem hiding this comment.
variable name tag is very confusing. Why not info , seems like this is the var name used everywhere else.
There was a problem hiding this comment.
to avoid double info, because it is a part of recv_info union, so it will be recv_info.tag_info
There was a problem hiding this comment.
FYI, we use info everywhere else, so I have no issue with double naming. tag_info is double-double naming :) If you have strong preference towards tag_info I can accept it.
|
👍 |
|
bot:pipe:retest |
|
@tonycurtis, can you please review? |
fixed |
|
@tonycurtis, do you have other comments? |
brminich
force-pushed
the
topic/ucp_api_imm_rx_compl
branch
from
a3fd63c
to
d8b829e
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
bot:pipe:retest |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
What
Add
recv_infotoucp_request_param_t, so that*recv_nbxfunction can get receive data details in case of immediate completion.Why ?
If operation completes immediately the callback is not invoked. Need to provide the length (and other info) of received data to the user.