Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UCP/AMO: Use remote_addr from AMO part of request instead of RMA #6004

Merged
merged 1 commit into from
Dec 10, 2020
Merged

UCP/AMO: Use remote_addr from AMO part of request instead of RMA #6004

merged 1 commit into from
Dec 10, 2020

Conversation

dmitrygx
Copy link
Member

@dmitrygx dmitrygx commented Dec 9, 2020

What

Use remote_addr from AMO part of request instead of RMA.

Why ?

Fixes possible correctness issue in the future if remote_addr moved to new offset in either AMO or RMA substructure of a UCP request.

How ?

Use send.amo.remote_addr instead of send.rma.remote_addr

@dmitrygx
Copy link
Member Author

@hoopoepg @yosefe could you review pls?

hoopoepg
hoopoepg approved these changes Dec 10, 2020
View reviewed changes
Copy link
Contributor

@hoopoepg hoopoepg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@yosefe yosefe merged commit d50c796 into openucx:master Dec 10, 2020
@it-is-a-robot it-is-a-robot mentioned this pull request Nov 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yosefe yosefe yosefe approved these changes

@hoopoepg hoopoepg hoopoepg approved these changes

@brminich brminich brminich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dmitrygx @yosefe @hoopoepg @brminich