Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UCT/IB: Fixes for SL selection (v1.10.x) #6037

Merged
merged 1 commit into from
Dec 18, 2020

Conversation

dmitrygx
Copy link
Member

What

Fixes for SL selection

Why ?

  1. Fixes SL (Etherhent priority) selection for RoCE devices.
  2. Fixes SL=15 selection.
  3. Covers more use cases in gtests.

How ?

  1. If the selected device has RoCE type, select SL from empty mask assuming that AR_ENABLE=no.
  2. SL mask is done for 16.
  3. Check reported string, and check different SLs instead of just 8.

src/uct/ib/mlx5/ib_mlx5.c Outdated Show resolved Hide resolved
@dmitrygx dmitrygx changed the title UCT/IB: Fixes for SL selection UCT/IB: Fixes for SL selection (v1.10.x) Dec 16, 2020
@dmitrygx
Copy link
Member Author

bot:pipe:retest

@dmitrygx
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dmitrygx
Copy link
Member Author

the failure is #6027

@dmitrygx
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dmitrygx
Copy link
Member Author

@yosefe ok to merge?

@yosefe yosefe merged commit a4feda2 into openucx:v1.10.x Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants