UCT/UD: Don't wake up remote peer for every ACKREQ packet #6218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoopoepg
approved these changes
Jan 27, 2021
Introduce a minimal interval for sending packets with SOLICITED flag, to avoid excessive interrupts on the remote peer which have a significant performance overhead.
yosefe
force-pushed
the
topic/uct-ud-dont-wake-up-remote-peer
branch
from
8599b3f
to
b21fe2a
Compare
brminich
approved these changes
Jan 28, 2021
dmitrygx
approved these changes
Jan 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Fix a performance degradation in an application, introduced by #5499
Elapsed time results (T is baseline), lower is better:
How
Set a minimal interval of requesting remote wakeup by sending ACK+REQ message with SOLICITED event.
Hopefully, ACKs would arrive by that time, so would not need to send ACK+REQ any more.