Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UCP/AM: Adjust max_short for UCP_AM_SEND_REPLY - v1.10.x #6733

Merged
merged 1 commit into from
May 7, 2021
Merged

UCP/AM: Adjust max_short for UCP_AM_SEND_REPLY - v1.10.x #6733

merged 1 commit into from
May 7, 2021

Conversation

chenyidu
Copy link
Contributor

What

Maximal size for eager short with reply protocol should subtract sizeof(ucs_ptr_map_key_t)

Why ?

Thes header of reply protocol is ucp_am_hdr_t + ucs_ptr_map_key_t.

@swx-jenkins3
Copy link
Collaborator

Can one of the admins verify this patch?

@brminich
Copy link
Contributor

ok to test

brminich
brminich reviewed Apr 29, 2021
View reviewed changes
src/ucp/core/ucp_am.c Outdated Show resolved Hide resolved
src/ucp/core/ucp_am.c Outdated Show resolved Hide resolved
src/ucp/core/ucp_am.c Outdated Show resolved Hide resolved
brminich
brminich reviewed Apr 29, 2021
View reviewed changes
src/ucp/core/ucp_am.c Outdated Show resolved Hide resolved
@brminich
Copy link
Contributor

bot:pipe:retest

@brminich
Copy link
Contributor

brminich commented May 3, 2021

@chenyidu, thanks for the patch!
Which org are you representing? Do you have signed contributor agreement?

@chenyidu
Copy link
Contributor Author

chenyidu commented May 3, 2021

@brminich I work for huawei that has joined UCF already. Do I still need to sign CLA ？

@yosefe
Copy link
Contributor

yosefe commented May 3, 2021

@chenyidu for Huawei, no need to sign a CLA.
However, can you please squash the commits and use Huawei email for the commit email?
currently it's <...@163.com>

@chenyidu
Copy link
Contributor Author

chenyidu commented May 3, 2021

@yosefe It has been changed according to your request

@yosefe
Copy link
Contributor

yosefe commented May 3, 2021

@yosefe It has been changed according to your request

Thank you!

@yosefe yosefe changed the title UCP/AM: Adjust max_short for UCP_AM_SEND_REPLY UCP/AM: Adjust max_short for UCP_AM_SEND_REPLY - v1.10.x May 3, 2021
@shamisp
Copy link
Contributor

shamisp commented May 3, 2021

@chenyidu Please add Huawei copyright to the top of modified files. Please update NEWS file with bug fix description.

@chenyidu
Copy link
Contributor Author

chenyidu commented May 3, 2021

@chenyidu Please add Huawei copyright to the top of modified files. Please update NEWS file with bug fix description.

@shamisp I added it, please check.

shamisp
shamisp reviewed May 3, 2021
View reviewed changes
NEWS Outdated Show resolved Hide resolved
@chenyidu chenyidu force-pushed the v1.10.x branch 2 times, most recently from 8a09b5b to 82fe821 Compare May 3, 2021 15:26
@shamisp
Copy link
Contributor

shamisp commented May 4, 2021

Looks good. Please squash into single commit. thanks !

@yosefe
Copy link
Contributor

yosefe commented May 5, 2021

@chenyidu can you please squash and rebase? thanks!

@chenyidu
Copy link
Contributor Author

chenyidu commented May 6, 2021

@chenyidu can you please squash and rebase? thanks!

@yosefe I don't have my laptop with me. I'll fix it later.

@yosefe yosefe merged commit b50b0af into openucx:v1.10.x May 7, 2021
@it-is-a-robot it-is-a-robot mentioned this pull request Nov 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shamisp shamisp shamisp left review comments

@yosefe yosefe yosefe approved these changes

@brminich brminich brminich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chenyidu @swx-jenkins3 @brminich @yosefe @shamisp