Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AZP/RELEASE: Fix github release pipeline conditions #7054

Merged
merged 1 commit into from
Jul 5, 2021

Conversation

yosefe
Copy link
Contributor

@yosefe yosefe commented Jul 3, 2021

What

Fix condition checking for release pipeline

Why

  • Fix that artifacts are not uploaded for tag trigger
  • Fix jucx publish

How

Build.Reason Trigger reason Build packages Upload release artifacts JUcx mode
PullRequest PR with "AZP/RELEASE"* commit title Yes No Build only
PullRequest PR without "AZP/RELEASE"* commit title No No Skip
ResourceTrigger Merge to master/release branch Yes No Snapshot
IndividualCI New tag matching v* pattern Yes Yes Release
  • Move conditions to upper layer script (az-pipelines-release.yml)
  • Use variables instead of parameters for jucx-publish.yml
  • Change container path in jucx pipeline to workaround docker run error

@yosefe yosefe added the WIP-DNM Work in progress / Do not review label Jul 3, 2021
@yosefe yosefe force-pushed the topic/azp-release-condition branch from 5ac152f to f0a7b0a Compare July 3, 2021 16:01
@yosefe yosefe force-pushed the topic/azp-release-condition branch from 7aa2a1a to 4e6bae4 Compare July 3, 2021 19:06
@yosefe yosefe removed the WIP-DNM Work in progress / Do not review label Jul 3, 2021
@yosefe
Copy link
Contributor Author

yosefe commented Jul 3, 2021

@avildema @petro-rudenko @shamisp can you pls take a look?

@shamisp
Copy link
Contributor

shamisp commented Jul 3, 2021

@yosefe - the table makes sense.

  • maybe use the opportunity to migrate to https://packagecloud.io
  • Related to above, we can use service to maintain nightly snapshot

@yosefe
Copy link
Contributor Author

yosefe commented Jul 5, 2021

@yosefe - the table makes sense.

  • maybe use the opportunity to migrate to https://packagecloud.io
  • Related to above, we can use service to maintain nightly snapshot

@shamisp the migration to packagecloud is in plans but it's large change which is outside the scope of this PR which intends to fix the release process for v1.11

@yosefe yosefe merged commit 92c9ff9 into openucx:v1.11.x Jul 5, 2021
@yosefe yosefe deleted the topic/azp-release-condition branch July 5, 2021 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants