Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UCT/TCP: Increase keepalive interval from 1 to 2 seconds and use system default for keepalive retries count [v1.11.x] #7117

Merged
merged 1 commit into from
Jul 18, 2021

Conversation

dmitrygx
Copy link
Member

What

Increase keepalive interval from 1 to 2 seconds and use system default for keepalive retries count.

Why ?

Fixes #6705.
Fixes #6471.

How ?

Backporting #7093.

Copy link
Contributor

@yosefe yosefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls update NEWS

@dmitrygx
Copy link
Member Author

pls update NEWS

done

NEWS Outdated
@@ -168,6 +168,7 @@
* Fixes in reachability of loopback ifaces
* Fixes addressing possible uninitialized memory accesses
* Fixes in error flow for endpoints created upon receiving connection request
* Fixes TCP keepalive false positive error detections
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes in TCP keepalive to avoid false-positive error detection

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@dmitrygx dmitrygx changed the title UCT/TCP: Increase keepalive interval from 1 to 2 seconds and use system default for keepalive retries count [v1.11.x]] UCT/TCP: Increase keepalive interval from 1 to 2 seconds and use system default for keepalive retries count [v1.11.x] Jul 17, 2021
@dmitrygx
Copy link
Member Author

@yosefe ok to merge?

@yosefe yosefe merged commit e312d18 into openucx:v1.11.x Jul 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants