Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UCT/TCP: Implement flush of all outstanding operations [v1.11.x] #7188

Merged
merged 1 commit into from
Aug 5, 2021

Conversation

dmitrygx
Copy link
Member

@dmitrygx dmitrygx commented Aug 4, 2021

backport of #7140 PR to v1.11.x branch to be included in 1.11.1 release version

What

Implement flush of all outstanding operations.

Why ?

To fix uct_ep_flush() which don't wait for all operations being completed. As a result if fixes the following case:

/* client */
for (i= 0; i < 1000; ++i) { 
    req = ucp_ep_tag_send_nb(ep)
    reqs.push_back(req);
}
wait_for_reqs(reqs);

req = ucp_ep_close_nb(ep, FLUSH);
wait_for_req(req);

exit(0);
/* server */
for (i = 0; i < 1000; ++i) {
    req = ucp_worker_tag_recv_nb(worker);
    reqs.push_back(req);
}
wait_for_reqs(reqs);

/* 998-999 completed successfully, but 1-2 completed with error  */

How ?

  1. Do PUT operation if last_acked_sn != tx.sn in EP
  2. Fix EP flush conditions when checking resources. Return UCS_OK if connection has already been closed.
  3. Fix tests.

Conflicts:
	src/tools/perf/lib/libperf_int.h
@yosefe
Copy link
Contributor

yosefe commented Aug 4, 2021

any conflicts?

@dmitrygx
Copy link
Member Author

dmitrygx commented Aug 4, 2021

any conflicts?

@yosefe only here -

void ucp_perf_thread_barrier(ucx_perf_context_t *perf);

here is what we we have in master (no empty lines between declarations):

void ucp_perf_thread_barrier(ucx_perf_context_t *perf);

@dmitrygx
Copy link
Member Author

dmitrygx commented Aug 5, 2021

@yosefe ok to merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants