UCM/BISTRO/TEST: Fix support for cuda memory hooks - v1.11.x #7209
+209
−95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a hooked function starts with instruction that refers global data (for example, "cmp $imm32, $disp32(%rip)") - we need to modify the instruction so it could be executed from is new location and still access the same global variable. Change Cuda hooks configuration so it can also support "bistro hooks without fallback to reloc" and test this mode in CI.
yosefe
changed the title
hoopoepg
approved these changes
Aug 9, 2021
|
Thanks @yosefe for the quick fix, the tests I've seen failing before pass with changes here. I'm going to run also the extended tests and report if I see any further issues. |
dmitrygx
approved these changes
Aug 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Backporting #7204 as it fixes a critical issue with Cuda memory hooks with 11.3/4
Fixes #7210