Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GTEST/UCP/WIREUP: Don't overwrite EP params from base test suite #7211

Merged
merged 1 commit into from
Aug 11, 2021
Merged

GTEST/UCP/WIREUP: Don't overwrite EP params from base test suite #7211

merged 1 commit into from
Aug 11, 2021

Conversation

dmitrygx
Copy link
Member

@dmitrygx dmitrygx commented Aug 9, 2021

What

The PR fixes setting EP params in UCP wireup keepalive test suite.

Why ?

No need to overwrite EP params from base test suite.

How ?

  1. Remove memset(&params, 0, sizeof(params)); at the beginning of the function.
  2. Assign field_mask field of ucp_ep_params_t by ORing values.

@dmitrygx
Copy link
Member Author

dmitrygx commented Aug 9, 2021

bot:pipe:retest

@dmitrygx
Copy link
Member Author

@brminich @hoopoepg could you review pls?

@yosefe yosefe merged commit d745991 into openucx:master Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yosefe yosefe yosefe approved these changes

@hoopoepg hoopoepg hoopoepg approved these changes

@brminich brminich brminich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dmitrygx @yosefe @hoopoepg @brminich