-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UCP: Reregister memh on CM switch. #7403
UCP: Reregister memh on CM switch. #7403
Conversation
void check_cm_fallback() | ||
{ | ||
if (get_num_cms() < 2) { | ||
UCS_TEST_SKIP_R("No CM for fallback to"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can create one boolean function "have_two_cm_components()" and use the macro UCS_TEST_SKIP_COND_P
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To check the number of CM components needs worker. Function in macro instantiates before test, so worker is unavailable: https://github.com/openucx/ucx/blob/master/test/gtest/ucp/test_ucp_sockaddr.cc#L1359
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right
test/gtest/ucp/test_ucp_sockaddr.cc
Outdated
protected: | ||
ucp_rsc_index_t get_num_cms() | ||
protected: | ||
const ucp_rsc_index_t get_num_cms() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ucp_rsc_index_t get_num_cms() const
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/__w/1/s/contrib/../test/gtest/ucp/test_ucp_sockaddr.cc: In member function ‘ucp_rsc_index_t test_ucp_sockaddr_cm_switch::get_num_cms() const’:
/__w/1/s/contrib/../test/gtest/ucp/test_ucp_sockaddr.cc:1358:47: error: passing ‘const test_ucp_sockaddr_cm_switch’ as ‘this’ argument discards qualifiers [-fpermissive]
const ucp_worker_h worker = sender().worker();
Removing const
c9df428
to
3ef257e
Compare
Some flake with tests on gpu-worker2 machine.
But sometimes it passes OK. Checking. But it always fails when the listener starts at |
it happens when @avildema is running docker tests inside GPU machines which create temporary network devices for docker |
1304d5a
to
d3f9f9c
Compare
What
Fixes segfault on emty memh when CM switches from rdmacm -> tcp (due to listener started on non RDMA NIC)