UCP/AM: Fix request datatype state during CM switch - v1.11.x #7436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When switching between transports, we can add new memry registration handles to req->send.state.dt by calling ucp_send_request_add_reg_lane() from ucp_do_am_zcopy_single(). Should not save 'state' before calling add_reg_lane() - otherwise the new memory registration will be overridden. This fixes failure on r-vmb-ppc-jenkins in test_ucp_sockaddr_cm_switch test with the symptom "Error: Input/output error". It is actually a local protection error (PD violation) due to using wrong uct_mem_h.
yosefe
changed the title
brminich
approved these changes
Sep 22, 2021
petro-rudenko
approved these changes
Sep 22, 2021
yosefe
deleted the
topic/ucp-am-fix-request-datatype-state-during-v1.11.x
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Backport #7432 to v1.11.x