-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IODEMO: fix progress loop #7662
IODEMO: fix progress loop #7662
Conversation
what failure does it fix? |
stuck with |
because progress_worker_event() returns false and we don't progress the io message? |
exactly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls update PR description with issue symptom
done |
Under shm transports, io_demo works with this PR. |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
2eaa923
to
faf5f43
Compare
What
Fix progress loop in io_demo
Why
Fixes a hang in io_demo test over shared memory transport
How
If
progress_worker_event()
returnsfalse
, we don't progress the io message. We have to progress io_msg and worker at least once to avoid the situation when io_msg is completed on previous iteration of worker progress.The issue is stable reproducible with shared memory transport