UCT/SM/CUDA: Fix common intra-node keepalive protocol #7780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yosefe
reviewed
Dec 8, 2021
dmitrygx
reviewed
Dec 8, 2021
src/uct/base/uct_iface.c
Outdated
|
|
||
| UCT_EP_KEEPALIVE_CHECK_PARAM(flags, comp); | ||
|
|
||
| if (*ka_p == NULL) { | ||
| status = uct_ep_keepalive_create(pid, ka_p); | ||
| status = uct_ep_keepalive_create(pid, ka_p); |
There was a problem hiding this comment.
do we really need has cross-if alignment by =?
There was a problem hiding this comment.
we have them a lot thru the code, but i can remove
src/uct/base/uct_iface.h
Outdated
| @@ -295,7 +295,7 @@ typedef struct uct_failed_iface { | |||
| * Keepalive info used by EP | |||
| */ | |||
| typedef struct uct_keepalive_info { | |||
| struct timespec start_time; /* Process start time */ | |||
| unsigned long start_time; /* Process start time */ | |||
There was a problem hiding this comment.
pls, remove extra whitespaces here and below
There was a problem hiding this comment.
ok, but typically we have more than one space for struct fields
brminich
force-pushed
the
uct/intra_node_ka_fix
branch
2 times, most recently
from
782cbc6
to
5dc7710
Compare
brminich
force-pushed
the
uct/intra_node_ka_fix
branch
from
5dc7710
to
2ab66ef
Compare
yosefe
reviewed
Dec 11, 2021
brminich
force-pushed
the
uct/intra_node_ka_fix
branch
from
c34cdc0
to
558b0c9
Compare
yosefe
reviewed
Dec 19, 2021
test/gtest/uct/test_peer_failure.cc
Outdated
Comment on lines
474
to
476
| ASSERT_TRUE(has_mm()); | ||
| uct_mm_ep_t *ep = ucs_derived_of(m_entity->ep(0), uct_mm_ep_t); | ||
| m_ka = &ep->keepalive; |
There was a problem hiding this comment.
minor: i would add a getter function to return ka pointer instead of caching it in a member variable
these 3 lines could be the body of that getter function
|
Is this PR ready to merge? |
yosefe
approved these changes
Jan 3, 2022
brminich
force-pushed
the
uct/intra_node_ka_fix
branch
from
65bc359
to
7135263
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Implement intra-node keep-alive protocol based on startime value from /proc/pid/stat
Why ?
The current implementation relies on stat() info performed on /proc/pid dir. This is incorrect, because the files in /proc have no existence of their own, and the info returned by stat() is not persistent.