UCM/BISTRO: Translate relative jumps #7866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yosefe
force-pushed
the
topic/ucm-bistro-translate-relative-jumps
branch
from
6fd49f4
to
85adf3a
Compare
yosefe
force-pushed
the
topic/ucm-bistro-translate-relative-jumps
branch
from
85adf3a
to
6c47694
Compare
|
@yosefe thanks for the patch, I can confirm on my end the segfault is gone after applying it. |
|
@hoopoepg can you pls take a look? |
hoopoepg
approved these changes
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Fix the issue described in #7791 (comment)
How
Bistro to handle functions that begin with a compare and short conditional jump, when need to jump more than 32-bit distance from the patched function to the hook code.