Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memtype cache fixes - v1.12.x #7909

Merged
merged 3 commits into from
Feb 7, 2022

Conversation

yosefe
Copy link
Contributor

@yosefe yosefe commented Feb 5, 2022

Why

Backport #7737 and #7865 to v1.12.x

Conflicts: cudamem.c, memtype_cache.c

dmitrygx and others added 3 commits February 5, 2022 15:55
- Reloc hooks are optional but are not the default. Default is bistro
  hooks on Cuda driver API.
- If UCM fails to install the configured hooks, do not create the memory
  type cache.
- If failed to create memtype cache once, don't try again.
- Use getauxv() API if possible instead of reading /proc/self/auxv
  directly - fixes permissions errors on some systems.
- Enable Cuda bistro hooks also with valgrind, since it doesn't affect
  heap memory allocations.
- Fix error message in tests.
@yosefe yosefe added this to the v1.12.1 milestone Feb 5, 2022
@yosefe yosefe added the Bugfix label Feb 5, 2022
@yosefe
Copy link
Contributor Author

yosefe commented Feb 7, 2022

@Akshay-Venkatesh @bureddy @dmitrygx can you pls take a look?

@yosefe yosefe merged commit 0796bf5 into openucx:v1.12.x Feb 7, 2022
@yosefe yosefe deleted the topic/memtype-cache-fixes-v1.12.x branch February 7, 2022 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants